Fix TrustyAI missing pylock.cpu.toml update#3306
Fix TrustyAI missing pylock.cpu.toml update#3306ayush17 wants to merge 1 commit intoopendatahub-io:mainfrom
Conversation
The previous PR opendatahub-io#3254 updated requirements.cpu.txt but the pylock.cpu.toml was not properly included. This regenerates both files using: FORCE_LOCKFILES_UPGRADE=1 make refresh-lock-files DIR=jupyter/trustyai/ubi9-python-3.12 This should fix the TrustyAI test failures on main. Made-with: Cursor
|
@ayush17 — This PR is from a fork. Recommended: Push your branch to the main repo for full CI: Then open a new PR from that branch. No push access? A maintainer will cherry-pick and test your changes. See CONTRIBUTING.md for details. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Repository UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDependency versions are bumped across two configuration files for a Jupyter/TrustyAI Python 3.12 CPU environment. Twenty-two packages receive version updates (including boto3, cryptography, transformers, uvicorn) with corresponding hash values recalculated. The lock file's exclusion timestamp advances from April 4 to April 7, 2026, and pyarrow's wheel set expands to include new architecture variants. No code logic is modified. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Actionable issuesinvoke major version bump (2.2.1→3.0.2): This crosses a major version boundary. Verify no breaking API changes impact downstream usage within this environment, as invoke is a task execution library with potential compatibility implications for build/deployment scripts. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
=====================================
Coverage 3.34% 3.34%
=====================================
Files 31 31
Lines 3562 3562
Branches 572 572
=====================================
Hits 119 119
Misses 3441 3441
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jiridanek
left a comment
There was a problem hiding this comment.
check-generated-code still fails, but if it has been failing more befoe and this is an improvement, then ok
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you @ayush17! |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
The previous PR #3254 updated
requirements.cpu.txtbut thepylock.cpu.tomlwas not properly included in the merge. This regenerates both lockfiles to fix the TrustyAI test failures on main.Changes
FORCE_LOCKFILES_UPGRADE=1 make refresh-lock-files DIR=jupyter/trustyai/ubi9-python-3.12Test Plan
Fixes test failures reported by @atheo89
Made with Cursor
Summary by CodeRabbit