RHOAIENG-64892: CVE-2026-48710 rhoai/odh-pipeline-runtime-pytorch-cuda-py312-rhel9: Starlette: Security restriction bypass via malformed HTTP Host header [rhoai-3.3]#3752
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jira-autofix[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Repository UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughThis PR updates the Starlette CVE tracking comment above the existing starlette>=1.0.1 constraint to reference RHOAIENG-64892, adds .agents/skills/README.md, rewrites AGENTS.md as a concise entry point, expands CONTRIBUTING.md and docs/agents/testing.md, and clarifies KONFLUX/ODH vs RHOAI build/pipeline conventions across ARCHITECTURE.md, docs/konflux.md, and docs/subscribed-builds.md; it also adds docs/cves/agents-cve-autofix.md and a small .gitignore tweak. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches⚔️ Resolve merge conflicts
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3752 +/- ##
=======================================
Coverage 27.46% 27.46%
=======================================
Files 38 38
Lines 4064 4064
Branches 670 670
=======================================
Hits 1116 1116
Misses 2859 2859
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…d HTTP Host header
b25451d to
5f406e0
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@dependencies/cve-constraints.txt`:
- Around line 25-27: The file contains duplicate CVE tracking comments for
CVE-2026-48710 (RHAIENG-5355 and RHOAIENG-64892) above the starlette constraint;
remove the redundant comment so only a single CVE tracking line remains (e.g.,
keep the RHOAIENG-64892 comment and delete the RHAIENG-5355 line) and leave the
existing starlette>=1.0.1 constraint unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Repository UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: cb2b07a2-1812-4059-b797-e1e11ed130dc
📒 Files selected for processing (1)
dependencies/cve-constraints.txt
Remove scope creep from CVE fix branch. Only the comment update in dependencies/cve-constraints.txt is relevant to CVE-2026-48710.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 106-108: Update the stale wording in CONTRIBUTING.md: change the
phrase "A fuller test-catalog document is planned in [issue `#3174`] as
`docs/agents/testing.md`." to reflect that docs/agents/testing.md now exists
(e.g., "See the test-catalog: docs/agents/testing.md" or similar active
reference), and ensure the link to issue `#3174` remains or is adjusted to point
to the new doc; update any nearby wording that implies the guide is pending so
CONTRIBUTING.md and the reference to docs/agents/testing.md are accurate and
current.
In `@docs/cves/agents-cve-autofix.md`:
- Around line 47-49: The doc contains conflicting verdict mappings for the same
dedup condition ("fix already present") — one place maps it to `already_fixed`
and another to `no_changes`; choose a single canonical verdict (prefer
`already_fixed` or `no_changes`) and update all instances so they are consistent
(including the sentence that begins "Check `dependencies/cve-constraints.txt`
..." and the other occurrences referenced around lines that map this condition)
by replacing the incorrect token with the chosen canonical token so the operator
behavior and run outcomes are deterministic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Repository UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3babf947-a0e0-4b53-880e-547c1b50e72d
📒 Files selected for processing (10)
.agents/skills/README.md.gitignoreAGENTS.mdARCHITECTURE.mdCONTRIBUTING.mdREADME.mddocs/agents/testing.mddocs/cves/agents-cve-autofix.mddocs/konflux.mddocs/subscribed-builds.md
✅ Files skipped from review due to trivial changes (3)
- .agents/skills/README.md
- .gitignore
- README.md
…ping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Closing — per-image RHOAIENG CVE trackers are now triaged as not_fixable via AGENTS.md instructions (PR #3780). The centralized fix for CVE-2026-48710 is already in |
Summary by CodeRabbit
Chores
Documentation