Skip to content

Update helpers submodule rhoai 3.3#48

Closed
threcc wants to merge 61 commits intoopendatahub-io:mainfrom
threcc:update-helpers-submodule-rhoai-3.3
Closed

Update helpers submodule rhoai 3.3#48
threcc wants to merge 61 commits intoopendatahub-io:mainfrom
threcc:update-helpers-submodule-rhoai-3.3

Conversation

@threcc
Copy link
Copy Markdown

@threcc threcc commented Mar 13, 2026

Summary by CodeRabbit

  • New Features

    • Added Tekton-based CI/CD pipeline configurations for automated builds and pull-request workflows.
    • Introduced multi-architecture Docker builds supporting x86_64 and ARM64.
  • Chores

    • Removed vulnerability scanning from CI/CD workflow.
    • Added Python and RPM dependency declarations.
    • Added git submodules for external tools.
    • Lowered Go toolchain requirement.
  • Documentation

    • Added Tekton workflow documentation and build instructions.

ckhordiasma and others added 30 commits February 17, 2026 11:28
- add rhoai-upgrade-helpers as a submodule

- use submodule instead of git clone

- use ose-cli image and remove oc and kubectl installs

- use requirements.txt
…lis-patch-3

Update odh-cli-v3-3-push.yaml
Added labels to Dockerfile for better metadata and description.
…lis-patch-4

Add metadata labels to Dockerfile.konflux
…hermetic

add files to support hermetic builds on konflux
…-latest-commit

update submodule - RHOAIENG-50691
…-latest-commit

update rhoai-upgrade-helpers submodule to point towards the latest commit
jstourac and others added 28 commits February 26, 2026 15:45
Merge the latest changes from the main branch into the rhoai-3.3 branch
Update rhoai-upgrade-helpers submodule to e503a66
* add yq submodule, at the v4.44.6 tag

* add yq source build

* add yq folder to prefetch

* fix missing param in pr pipeline

* fix gitmodules url
…ocker digest to b3b98e0 (#145)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
update rhoa-upgrade-helpers to current main from odh remote
…ocker digest to e421039 (#146)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sync from opendathub-io/odh-cli@main
…ocker digest to 71101fd (#154)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sync from opendatahub-io/odh-cli
Switch back to Go 1.25.7 and remove vulncheck from CI and the
default check target. The standalone `make vulncheck` target is
kept for manual use.

Made-with: Cursor
…ocker digest to 6da1160 (#166)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Signed-off-by: Nelesh Singla <117123879+nsingla@users.noreply.github.com>
add directory for component backups to be stored and mounted
Signed-off-by: Nelesh Singla <117123879+nsingla@users.noreply.github.com>
…ocker digest to 3cdf0d1 (#167)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 5749ec49-8dae-4c68-b51b-025003544d6e

📥 Commits

Reviewing files that changed from the base of the PR and between 7d65e7f and ca5d27b.

📒 Files selected for processing (21)
  • .github/workflows/ci.yml
  • .gitmodules
  • .tekton/README.md
  • .tekton/odh-cli-pull-request.yaml
  • .tekton/odh-cli-v3-3-push.yaml
  • .tekton/odh-cli.yaml
  • Dockerfile
  • Dockerfile.konflux
  • Makefile
  • docs/code-review.md
  • docs/quality.md
  • docs/setup.md
  • go.mod
  • requirements-build.txt
  • requirements.in
  • requirements.txt
  • rhoai-upgrade-helpers
  • rpms.in.yaml
  • rpms.lock.yaml
  • ubi.repo
  • yq

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


📝 Walkthrough

Walkthrough

This pull request introduces infrastructure and dependency changes for a multi-architecture container build and modernized CI/CD pipeline. It removes vulnerability scanning from CI workflows, adds Tekton PipelineRun manifests for PR and push-based builds, introduces a multi-stage cross-compilation Dockerfile (Dockerfile.konflux), adds two git submodules (rhoai-upgrade-helpers and yq), includes pinned Python dependencies and RPM lockfiles, and introduces a new Yum repository configuration for Red Hat UBI 9. The Go toolchain requirement is lowered to 1.25.7. Documentation is updated to reflect the removal of vulnerability checking.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~70 minutes

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@threcc threcc closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants