Skip to content

Remove promptMangement devFlag and move it to TP feature flag #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divyanshiGupta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove promptMangement devFlag and move it to TP feature flag #6897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export type DashboardConfig = K8sResourceCommon & {
projectRBAC: boolean;
deploymentWizardYAMLViewer: boolean;
vLLMDeploymentOnMaaS: boolean;
promptManagement: boolean;
};
// Intentionally disjointed from the CRD, we should move away from this code-wise now; CRD later
// groupsConfig?: {
Expand Down
1 change: 1 addition & 0 deletions backend/src/utils/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ export const blankDashboardCR: DashboardConfig = {
projectRBAC: true,
deploymentWizardYAMLViewer: false,
vLLMDeploymentOnMaaS: false,
promptManagement: false,
},
notebookController: {
enabled: true,
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/__mocks__/mockDashboardConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export type MockDashboardConfigType = {
disableLLMd?: boolean;
deploymentWizardYAMLViewer?: boolean;
vLLMDeploymentOnMaaS?: boolean;
promptManagement?: boolean;
genAiStudioConfig?: {
aiAssetCustomEndpoints?: {
externalProviders?: boolean;
Expand Down Expand Up @@ -107,6 +108,7 @@ export const mockDashboardConfig = ({
disableLLMd = false,
deploymentWizardYAMLViewer = false,
vLLMDeploymentOnMaaS = false,
promptManagement = false,
hardwareProfileOrder = ['test-hardware-profile'],
genAiStudioConfig = {
aiAssetCustomEndpoints: {
Expand Down Expand Up @@ -283,6 +285,7 @@ export const mockDashboardConfig = ({
disableLLMd,
deploymentWizardYAMLViewer,
vLLMDeploymentOnMaaS,
promptManagement,
},
notebookController: {
enabled: !disableNotebookController,
Expand Down
1 change: 1 addition & 0 deletions frontend/src/concepts/areas/const.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const techPreviewFlags = {
observabilityDashboard: false,
deploymentWizardYAMLViewer: false,
vLLMDeploymentOnMaaS: false,
promptManagement: false,
} satisfies Partial<DashboardCommonConfig>;

export const devTemporaryFeatureFlags = {
Expand Down
1 change: 1 addition & 0 deletions frontend/src/k8sTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,6 +1312,7 @@ export type DashboardCommonConfig = {
disableLLMd?: boolean;
deploymentWizardYAMLViewer?: boolean;
vLLMDeploymentOnMaaS?: boolean;
promptManagement?: boolean;
};

// [1] Intentionally disjointed fields from the CRD in this type definition
Expand Down
2 changes: 2 additions & 0 deletions manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ spec:
type: boolean
deploymentWizardYAMLViewer:
type: boolean
promptManagement:
type: boolean
x-kubernetes-validations:
- rule: '!has(self.disableAcceleratorProfiles) || self.disableAcceleratorProfiles == oldSelf.disableAcceleratorProfiles'
message: 'DEPRECATED: spec.dashboardConfig.disableAcceleratorProfiles must be removed or left unchanged.'
Expand Down
2 changes: 1 addition & 1 deletion packages/gen-ai/frontend/src/odh/extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const extensions: (NavExtension | RouteExtension | AreaExtension | AIAssetsTabEx
properties: {
id: PROMPT_MANAGEMENT,
reliantAreas: [PLUGIN_GEN_AI],
devFlags: [PROMPT_MANAGEMENT],
featureFlags: [PROMPT_MANAGEMENT],
},
},
{
Expand Down
Loading