Trim response to just needed body#7205
Trim response to just needed body#7205nananosirova wants to merge 1 commit intoopendatahub-io:v3.3.0-fixesfrom
Conversation
Signed-off-by: Nana Nosirova <10577112+nananosirova@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.3.0-fixes #7205 +/- ##
================================================
- Coverage 64.25% 64.25% -0.01%
================================================
Files 2418 2418
Lines 72025 72025
Branches 18085 18085
================================================
- Hits 46283 46280 -3
- Misses 25742 25745 +3 see 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
https://redhat.atlassian.net/browse/RHOAIENG-57750
Description
Trim the k8 api response in NIM serving route to return only the body field instead of the whole response object.
How Has This Been Tested?
While logged into the dashboard, navigate to
<base-url>/api/nim-serving/apiKeySecret.With no NIM
AccountCR on the cluster, the endpoint returns 404 response object.After applying a test
AccountCR and linkedSecret:It returns only the body.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main