Skip to content

Trim response to just needed body#7207

Merged
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:v2.29.0-fixesfrom
nananosirova:trim-response-2.16
Apr 13, 2026
Merged

Trim response to just needed body#7207
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:v2.29.0-fixesfrom
nananosirova:trim-response-2.16

Conversation

@nananosirova
Copy link
Copy Markdown
Contributor

@nananosirova nananosirova commented Apr 13, 2026

https://redhat.atlassian.net/browse/RHOAIENG-57753

Description

Trim the k8 api response in NIM serving route to return only the body field instead of the whole response object.

How Has This Been Tested?

While logged into the dashboard, navigate to <base-url>/api/nim-serving/apiKeySecret.
When there are no Secrets, the endpoint should return 404 response.
Create secret:

apiVersion: v1
kind: Secret
metadata:
  name: nvidia-nim-access
  namespace: redhat-ods-applications
type: Opaque
data:
  foo: YmFy

Going back to the endpoint, it should return the response body only.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Signed-off-by: Nana Nosirova <10577112+nananosirova@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • master
  • incubation
  • rhoai

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 174e3beb-b27d-42cf-9937-92c58b7bed58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from christianvogt and pnaik1 April 13, 2026 13:38
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nananosirova nananosirova changed the title trim response to just needed body Trim response to just needed body Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.60%. Comparing base (eb5b425) to head (c747317).
⚠️ Report is 1 commits behind head on v2.29.0-fixes.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           v2.29.0-fixes    #7207      +/-   ##
=================================================
+ Coverage          85.58%   85.60%   +0.02%     
=================================================
  Files               1350     1350              
  Lines              30833    30833              
  Branches            8596     8596              
=================================================
+ Hits               26387    26395       +8     
+ Misses              4446     4438       -8     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5b425...c747317. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-merge-bot openshift-merge-bot Bot merged commit 2aa1a93 into opendatahub-io:v2.29.0-fixes Apr 13, 2026
5 of 7 checks passed
andrewballantyne added a commit to red-hat-data-services/odh-dashboard that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants