Trim response to just needed body#7207
Trim response to just needed body#7207openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:v2.29.0-fixesfrom
Conversation
Signed-off-by: Nana Nosirova <10577112+nananosirova@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.29.0-fixes #7207 +/- ##
=================================================
+ Coverage 85.58% 85.60% +0.02%
=================================================
Files 1350 1350
Lines 30833 30833
Branches 8596 8596
=================================================
+ Hits 26387 26395 +8
+ Misses 4446 4438 -8 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2aa1a93
into
opendatahub-io:v2.29.0-fixes
trim response to just needed body (opendatahub-io#7207)
https://redhat.atlassian.net/browse/RHOAIENG-57753
Description
Trim the k8 api response in NIM serving route to return only the body field instead of the whole response object.
How Has This Been Tested?
While logged into the dashboard, navigate to
<base-url>/api/nim-serving/apiKeySecret.When there are no Secrets, the endpoint should return 404 response.
Create secret:
Going back to the endpoint, it should return the response body only.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main