Skip to content

feat(automl): add Prediction type column to AutoML runs table#7260

Merged
openshift-merge-bot[bot] merged 2 commits intoopendatahub-io:mainfrom
nickmazzi:nmazzite-RHOAIENG-58441
Apr 15, 2026
Merged

feat(automl): add Prediction type column to AutoML runs table#7260
openshift-merge-bot[bot] merged 2 commits intoopendatahub-io:mainfrom
nickmazzi:nmazzite-RHOAIENG-58441

Conversation

@nickmazzi
Copy link
Copy Markdown
Contributor

https://issues.redhat.com/browse/RHOAIENG-58441

Description

Adds a Prediction type column to the AutoML runs table, displayed after the Description column. The column shows the friendly label for the run's task_type (e.g., "Binary classification", "Regression", "Time series forecasting") using the existing TASK_TYPE_LABELS mapping.

Changes:

  • columns.ts — Added a "Prediction type" column and rebalanced column widths (20/25/15/15/10) with Description remaining the largest.
  • AutomlRunsTableRow.tsx — Renders the prediction type label using the new getTaskType utility. Shows when runtime_config.parameters is absent; defaults to "Time series forecasting" when parameters exist but task_type is missing.
  • utils.ts — Extracted a shared getTaskType(pipelineRun) utility that encapsulates the task type extraction and fallback logic. Also refactored isTabularRun to use it internally.
  • AutomlResultsContext.ts — Refactored to use getTaskType instead of inline hasOwnProperty checks, consolidating the fallback logic in one place.
BeforeAfter
image image

How Has This Been Tested?

  • Updated unit tests in AutomlRunsTableRow.spec.tsx — all 25 tests pass.
  • Existing AutomlResultsContext.spec.tsx tests pass (19 tests).

Test Impact

Added 3 new unit tests in AutomlRunsTableRow.spec.tsx:

  • should render friendly prediction type label — verifies 'binary' renders as "Binary classification"
  • should render em dash when runtime_config is missing — verifies when runtime_config is undefined
  • should default prediction type to time series forecasting when task_type is missing — verifies the timeseries fallback when parameters exist but task_type is absent

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Display the task_type for each run as a friendly label (e.g.,
"Binary classification") after the Description column. Extract
shared getTaskType utility to consolidate fallback logic across
AutomlRunsTableRow and AutomlResultsContext.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress This PR is in WIP state label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 15, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Warning

Rate limit exceeded

@nickmazzi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 47 minutes and 9 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 9 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2776608e-a100-4ffe-88e9-dcbdddc5358a

📥 Commits

Reviewing files that changed from the base of the PR and between ea50e83 and 52a35d4.

📒 Files selected for processing (5)
  • packages/automl/frontend/src/app/components/AutomlRunsTable/AutomlRunsTableRow.tsx
  • packages/automl/frontend/src/app/components/AutomlRunsTable/__tests__/AutomlRunsTableRow.spec.tsx
  • packages/automl/frontend/src/app/components/AutomlRunsTable/columns.ts
  • packages/automl/frontend/src/app/context/AutomlResultsContext.ts
  • packages/automl/frontend/src/app/utilities/utils.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nickmazzi
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nickmazzi nickmazzi marked this pull request as ready for review April 15, 2026 18:21
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress This PR is in WIP state label Apr 15, 2026
@openshift-ci openshift-ci Bot requested review from GAUNSD and daniduong April 15, 2026 18:21
Copy link
Copy Markdown
Contributor

@GAUNSD GAUNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GAUNSD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit cae3a09 into opendatahub-io:main Apr 15, 2026
51 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.82%. Comparing base (3ef417a) to head (52a35d4).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7260      +/-   ##
==========================================
+ Coverage   64.80%   64.82%   +0.01%     
==========================================
  Files        2441     2442       +1     
  Lines       75996    76015      +19     
  Branches    19158    19164       +6     
==========================================
+ Hits        49253    49276      +23     
+ Misses      26743    26739       -4     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea50e83...52a35d4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants