Skip to content

chore(autorag+automl): RESTful refactor of S3 BFF endpoints#7358

Draft
GAUNSD wants to merge 3 commits intoopendatahub-io:mainfrom
GAUNSD:gmurcia/s3-bff-endpoints
Draft

chore(autorag+automl): RESTful refactor of S3 BFF endpoints#7358
GAUNSD wants to merge 3 commits intoopendatahub-io:mainfrom
GAUNSD:gmurcia/s3-bff-endpoints

Conversation

@GAUNSD
Copy link
Copy Markdown
Contributor

@GAUNSD GAUNSD commented Apr 22, 2026

Issues

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress This PR is in WIP state label Apr 22, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d7799fdf-33ab-4887-ab6a-b1fa994234f1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign daodaonocode for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.03%. Comparing base (06561b0) to head (13db237).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7358      +/-   ##
==========================================
+ Coverage   63.89%   65.03%   +1.14%     
==========================================
  Files        2513     2458      -55     
  Lines       77939    76402    -1537     
  Branches    19818    19278     -540     
==========================================
- Hits        49797    49691     -106     
+ Misses      28142    26711    -1431     

see 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06561b0...13db237. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

  Propagate S3 endpoint RESTful refactor from OpenAPI specs to BFF Go handlers and frontend TypeScript callers in both automl and autorag.

  - BFF handlers (s3_handler.go): extract key from URL path param (ps.ByName) instead of query string; update signatures and doc comments.
  - BFF routing (app.go): update path constants to use :key path segment.
  - Frontend API callers (api/s3.ts): embed key in URL path via encodeURIComponent instead of query param.
  - Frontend hooks (queries.ts, mutations.ts): rewrite fetch/XHR URLs to use /s3/files/<key> path.

Generated-by: Claude Opus 4.6 noreply@anthropic.com
Co-authored-by: Claude Opus 4.6 noreply@anthropic.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant