add missing async checkinferenceservice#7361
add missing async checkinferenceservice#7361sridarna wants to merge 1 commit intoopendatahub-io:v3.4.0-fixesfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.4.0-fixes #7361 +/- ##
================================================
- Coverage 64.93% 63.76% -1.17%
================================================
Files 2442 2497 +55
Lines 76045 77587 +1542
Branches 19184 19729 +545
================================================
+ Hits 49378 49475 +97
- Misses 26667 28112 +1445 see 68 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
The fix for other model serving tests have been done in this pr #7343.
This new pr covers the missing testSingleModelAdminCreation.cy e2e test file.
This missing test file is fixed in main with PR #7004 has this async checkInferenservice step.
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main