Skip to content

add missing async checkinferenceservice#7361

Open
sridarna wants to merge 1 commit intoopendatahub-io:v3.4.0-fixesfrom
sridarna:fix-checkinferenceservicestate-singlemodelserving-e2e-test
Open

add missing async checkinferenceservice#7361
sridarna wants to merge 1 commit intoopendatahub-io:v3.4.0-fixesfrom
sridarna:fix-checkinferenceservicestate-singlemodelserving-e2e-test

Conversation

@sridarna
Copy link
Copy Markdown
Contributor

@sridarna sridarna commented Apr 22, 2026

Description

The fix for other model serving tests have been done in this pr #7343.
This new pr covers the missing testSingleModelAdminCreation.cy e2e test file.
This missing test file is fixed in main with PR #7004 has this async checkInferenservice step.

How Has This Been Tested?

image

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • master
  • incubation
  • rhoai

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: effa38eb-ef41-4095-ad1d-141c7e34262a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from FedeAlonso and antowaddle April 22, 2026 20:28
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dgutride for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.76%. Comparing base (59d9f8b) to head (de6c2d2).
⚠️ Report is 1 commits behind head on v3.4.0-fixes.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           v3.4.0-fixes    #7361      +/-   ##
================================================
- Coverage         64.93%   63.76%   -1.17%     
================================================
  Files              2442     2497      +55     
  Lines             76045    77587    +1542     
  Branches          19184    19729     +545     
================================================
+ Hits              49378    49475      +97     
- Misses            26667    28112    +1445     

see 68 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d9f8b...de6c2d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant