Skip to content

fix: rename odh-u-spin to ai-u-spin from mod arch library #7362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenny-s51 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: rename odh-u-spin to ai-u-spin from mod arch library #7362

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b067dae
fix: rename odh-u-spin to ai-u-spin and bump mod-arch-shared
jenny-s51 Apr 21, 2026
5e65167
docs: update css-patternfly rule with ai-u-spin shared utility class
jenny-s51 Apr 21, 2026
57cc12f
fix(deps): align mod-arch-core to ^1.15.4 to satisfy mod-arch-shared …
jenny-s51 Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .claude/rules/css-patternfly.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,11 @@ Follow the project's BEM-like convention. Custom block-level classes must be nam

| Type | Pattern | Example |
|------|---------|---------|
| Block | `{prefix}-{name}` | `odh-card`, `autorag-leaderboard` |
| Element | `{prefix}-{block}__{element}` | `odh-card__footer`, `autorag-leaderboard__header` |
| Modifier | `m-{modifier}` or `{prefix}-m-{modifier}` | `m-disabled`, `m-is-selected`, `odh-m-doc` |
| Utility | `{prefix}-u-{name}` | `odh-u-spin`, `odh-u-scrollable` |
| Block | `odh-{name}` | `odh-card`, `odh-list-item` |
| Element | `odh-{block}__{element}` | `odh-card__footer`, `odh-list-item__doc-text` |
| Modifier | `m-{modifier}` or `odh-m-{modifier}` | `m-disabled`, `m-is-selected`, `odh-m-doc` |
| Utility | `odh-u-{name}` | `odh-u-scrollable` |
| Shared utility | `ai-u-{name}` | `ai-u-spin` (from mod-arch-shared) |

## PF Component Overrides

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ body,
}
}

.odh-u-spin {
.ai-u-spin {
animation: pf-v6-c-spinner-animation-rotate 3s linear infinite;
}

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/concepts/kueue/__tests__/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ describe('getKueueStatusInfo', () => {
const info = getKueueStatusInfo(KueueWorkloadStatus.Admitted);
expect(info.label).toBe('Starting');
expect(info.color).toBe('blue');
expect(info.iconClassName).toBe('odh-u-spin');
expect(info.iconClassName).toBe('ai-u-spin');
});

it('should return correct info for Complete', () => {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/concepts/kueue/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export const getKueueStatusInfo = (status: KueueWorkloadStatus): KueueStatusInfo
label: 'Starting',
color: 'blue',
IconComponent: InProgressIcon,
iconClassName: 'odh-u-spin',
iconClassName: 'ai-u-spin',
};
case KueueWorkloadStatus.Complete:
return {
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/concepts/modelServing/ModelStatusIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const ModelStatusIcon: React.FC<ModelStatusIconProps> = ({
return {
label: 'Stopping',
color: 'grey',
icon: <InProgressIcon className="odh-u-spin" />,
icon: <InProgressIcon className="ai-u-spin" />,
message: 'Model deployment is stopping.',
};
}
Expand All @@ -63,7 +63,7 @@ export const ModelStatusIcon: React.FC<ModelStatusIconProps> = ({
return {
label: 'Starting',
color: 'blue',
icon: <InProgressIcon className="odh-u-spin" />,
icon: <InProgressIcon className="ai-u-spin" />,
message: 'Model deployment is starting.',
};
}
Expand All @@ -81,7 +81,7 @@ export const ModelStatusIcon: React.FC<ModelStatusIconProps> = ({
return {
label: 'Starting',
color: 'blue',
icon: <InProgressIcon className="odh-u-spin" />,
icon: <InProgressIcon className="ai-u-spin" />,
message: 'Model deployment is starting.',
};
case ModelDeploymentState.FAILED_TO_LOAD:
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/concepts/notebooks/NotebookStatusLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const NotebookStatusLabel: React.FC<NotebookStateStatusProps> = ({
return {
label: 'Stopping',
color: 'grey',
icon: <InProgressIcon className="odh-u-spin" />,
icon: <InProgressIcon className="ai-u-spin" />,
};
}
if (kueueStatus?.status && KUEUE_STATUSES_OVERRIDE_WORKBENCH.includes(kueueStatus.status)) {
Expand All @@ -70,7 +70,7 @@ const NotebookStatusLabel: React.FC<NotebookStateStatusProps> = ({
return {
label: 'Starting',
color: 'blue',
icon: <InProgressIcon className="odh-u-spin" />,
icon: <InProgressIcon className="ai-u-spin" />,
};
}
if (isRunning) {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/concepts/notebooks/StartNotebookModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ const StartNotebookModal: React.FC<StartNotebookModalProps> = ({
<Flex gap={{ default: 'gapSm' }}>
{(!spawnStatus || spawnStatus.status === AlertVariant.info) && inProgress ? (
<FlexItem>
<InProgressIcon style={{ color: BrandIconColor.var }} className="odh-u-spin" />
<InProgressIcon style={{ color: BrandIconColor.var }} className="ai-u-spin" />
</FlexItem>
) : null}
<FlexItem>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/concepts/pipelines/content/PipelineComponentStatusIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const STATUS_CONFIG: Record<StatusType, StatusConfig> = {
},
[StatusType.IN_PROGRESS]: {
icon: InProgressIcon,
className: 'odh-u-spin',
className: 'ai-u-spin',
},
[StatusType.SUCCESS]: {
icon: CheckCircleIcon,
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const ModelRegistryTableRowStatus: React.FC<ModelRegistryTableRowStatusPr
// Degrading
else if (degradedCondition?.status === ConditionStatus.True) {
statusLabel = ModelRegistryStatusLabel.Degrading;
icon = <InProgressIcon className="odh-u-spin" />;
icon = <InProgressIcon className="ai-u-spin" />;
popoverTitle = 'Service is degrading';
}
// Available
Expand All @@ -88,7 +88,7 @@ export const ModelRegistryTableRowStatus: React.FC<ModelRegistryTableRowStatusPr
// Progressing
else if (progressCondition?.status === ConditionStatus.True) {
statusLabel = ModelRegistryStatusLabel.Progressing;
icon = <InProgressIcon className="odh-u-spin" />;
icon = <InProgressIcon className="ai-u-spin" />;
status = 'info';
}
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/projects/screens/detail/notebooks/NotebookImageDisplayName.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ export const NotebookImageDisplayName = ({
<FlexItem>
<Tooltip content="Updating version" data-testid="updating-image-icon-tooltip">
<InProgressIcon
className="odh-u-spin"
className="ai-u-spin"
style={{ cursor: 'pointer' }}
data-testid="updating-image-icon"
/>
Expand Down
2 changes: 1 addition & 1 deletion packages/automl/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"es-toolkit": "^1.44.0",
"lodash-es": "^4.17.15",
"mod-arch-core": "^1.6.0",
"mod-arch-shared": "^1.5.0",
"mod-arch-shared": "^1.15.4",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"react": "^18",
"react-dom": "^18",
"react-hook-form": "^7.71.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/autorag/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"echarts": "^5.6.0",
"es-toolkit": "^1.44.0",
"mod-arch-core": "^1.6.0",
"mod-arch-shared": "^1.5.0",
"mod-arch-shared": "^1.15.4",
"react": "^18",
"react-dom": "^18",
"react-hook-form": "^7.71.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/eval-hub/frontend/src/app/components/EvaluationStatusLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const statusMap: Record<EvaluationJobState, StatusConfig> = {
stopping: {
label: 'Canceling',
color: 'grey',
icon: <InProgressIcon className="odh-u-spin" />,
icon: <InProgressIcon className="ai-u-spin" />,
},
stopped: {
label: 'Stopped',
Expand Down
2 changes: 1 addition & 1 deletion packages/gen-ai/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"@patternfly/react-templates": "^6.3.1",
"immer": "^11.1.3",
"mod-arch-core": "^1.2.0",
"mod-arch-shared": "^1.2.0",
"mod-arch-shared": "^1.15.4",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router": "^7.12.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/notebooks/upstream/workspaces/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
"lodash-es": "^4.17.15",
"mod-arch-core": "^1.10.2",
"mod-arch-kubeflow": "^1.10.2",
"mod-arch-shared": "^1.10.2",
"mod-arch-shared": "^1.15.4",
"react": "^18",
"react-dom": "^18",
"react-router": "^7.5.2",
Expand Down
Loading