Skip to content

Rename oauth-proxy progression steps to auth proxy for kube-rbac-proxy migration#7373

Merged
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:v3.3.0-fixesfrom
nananosirova:RHOAIENG-41618
Apr 23, 2026
Merged

Rename oauth-proxy progression steps to auth proxy for kube-rbac-proxy migration#7373
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:v3.3.0-fixesfrom
nananosirova:RHOAIENG-41618

Conversation

@nananosirova
Copy link
Copy Markdown
Contributor

@nananosirova nananosirova commented Apr 23, 2026

  • Rename oauth-proxy progression steps to auth proxy for kube-rbac-proxy migration

  • address ai comments

  • fix tests

(cherry picked from commit a474209)

https://redhat.atlassian.net/browse/RHOAIENG-41618

Tested against 3.3-latest to make sure the changes work:
image

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5d000fa6-f905-4293-b3f6-7fb182d1abd2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…y migration (opendatahub-io#6546)

* Rename oauth-proxy progression steps to auth proxy for kube-rbac-proxy migration

* address ai comments

* fix tests

(cherry picked from commit a474209)
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.15%. Comparing base (dca3b1c) to head (0b6ed88).
⚠️ Report is 1 commits behind head on v3.3.0-fixes.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           v3.3.0-fixes    #7373      +/-   ##
================================================
- Coverage         64.27%   64.15%   -0.13%     
================================================
  Files              2421     2421              
  Lines             72228    72231       +3     
  Branches          18137    18140       +3     
================================================
- Hits              46426    46338      -88     
- Misses            25802    25893      +91     
Files with missing lines Coverage Δ
...ntend/src/concepts/__tests__/mockNotebookStates.ts 88.88% <ø> (ø)
frontend/src/types.ts 100.00% <100.00%> (ø)
frontend/src/utilities/notebookControllerUtils.ts 71.36% <100.00%> (+0.38%) ⬆️

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca3b1c...0b6ed88. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit f96a1c3 into opendatahub-io:v3.3.0-fixes Apr 23, 2026
118 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants