Skip to content

fix: Use full page navigation for OIDC logout instead of AJAX fetch (#7083)#7379

Merged
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:v3.3.0-fixesfrom
GowthamShanmugam:RHOAIENG-59420
Apr 23, 2026
Merged

fix: Use full page navigation for OIDC logout instead of AJAX fetch (#7083)#7379
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:v3.3.0-fixesfrom
GowthamShanmugam:RHOAIENG-59420

Conversation

@GowthamShanmugam
Copy link
Copy Markdown
Contributor

The dashboard used fetch('/oauth2/sign_out') (AJAX) to trigger logout. When kube-auth-proxy responds with a 302 redirect to the IdP's end_session_endpoint (e.g. Microsoft Entra ID), the browser blocks the cross-origin redirect due to CORS policy. This prevents the IdP session from being terminated, causing immediate re-authentication.

Replace fetch() with window.location.href to perform a full page navigation, allowing the browser to follow the 302 redirect chain to the IdP logout page and back.

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

…pendatahub-io#7083)

The dashboard used fetch('/oauth2/sign_out') (AJAX) to trigger logout.
When kube-auth-proxy responds with a 302 redirect to the IdP's
end_session_endpoint (e.g. Microsoft Entra ID), the browser blocks
the cross-origin redirect due to CORS policy. This prevents the IdP
session from being terminated, causing immediate re-authentication.

Replace fetch() with window.location.href to perform a full page
navigation, allowing the browser to follow the 302 redirect chain
to the IdP logout page and back.

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
Co-authored-by: Manaswini Das <dasmanaswini10@gmail.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6aed1b26-7d4a-4da0-ab5c-33f578a32820

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 8316555 into opendatahub-io:v3.3.0-fixes Apr 23, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants