-
Notifications
You must be signed in to change notification settings - Fork 37
odh-33627: add new topic on configuring model catalog source files #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
odh-33627: add new topic on configuring model catalog source files #1047
Conversation
WalkthroughDocumentation for configuring model catalog sources in OpenShift is added: a new procedure module is created and included in the working-with-the-model-catalog assembly. The module describes prerequisites, editing the model-catalog-sources ConfigMap, required fields, sample configs, and verification steps. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
assemblies/working-with-the-model-catalog.adoc(1 hunks)modules/configuring-model-catalog-sources-in-openshift.adoc(1 hunks)
🔇 Additional comments (4)
modules/configuring-model-catalog-sources-in-openshift.adoc (3)
1-13: Well-structured prerequisites and introduction.The module header, abstract, and prerequisites are clear and appropriately scoped.
54-58: Clear and actionable verification steps.The verification section effectively guides users on how to confirm their configuration in the OpenShift AI dashboard, with appropriate conditional guidance for labeled vs. unlabeled catalogs.
60-61: Verify and clean up external link formatting.The additional resources section provides a useful reference link. Please verify that the GitHub URL is current and check for any trailing whitespace after the closing bracket on line 61 (AsciiDoc is sensitive to formatting).
assemblies/working-with-the-model-catalog.adoc (1)
11-11: Correct include directive placement and syntax.The new include is properly formatted and logically positioned within the assembly. The leveloffset matches existing includes for consistency.
| . Click *Save*. | ||
|
|
||
| .Verification | ||
| . In the OpenShift AI dashboard, click *AI hub -> Catalog*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel, this implies that the changes are reflected immediately. That is however, is not the case, it can take a few minutes for the changes to be reflected. To make it immediately reflect, one has to kill the catalog pod and let it get re-spinned.
HTML preview:
Summary by CodeRabbit