-
Notifications
You must be signed in to change notification settings - Fork 37
RHOAING-32257 Storage size note #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
RHOAING-32257 Storage size note #921
Conversation
WalkthroughAdds an informational note to the Verification section of the PVC default size configuration doc describing the AWS EBS VolumeModificationRateExceeded error observed when resizing EBS-backed PVCs, clarifying it is an AWS service limit affecting all EBS-backed workloads and showing the ebs.csi.aws.com error example. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
modules/configuring-the-default-pvc-size-for-your-cluster.adoc (2)
28-31: Drop surrounding quotes in the code block and keep the exact message text.Code blocks shouldn’t wrap the message in quotes; show the log line verbatim and avoid trailing punctuation that isn’t in the real error.
-"VolumeModificationRateExceeded: You've reached the maximum modification rate per volume limit. Wait at least 6 hours between modifications per EBS volume". +VolumeModificationRateExceeded: You've reached the maximum modification rate per volume limit. Wait at least 6 hours between modifications per EBS volume.
36-39: Add an AWS reference in Additional resources.Link to the official Amazon EBS docs for volume modification limits.
* link:https://docs.redhat.com/en/documentation/openshift_container_platform/{ocp-latest-version}/html/storage/understanding-persistent-storage[Understanding persistent storage] +* link:https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/volume-modification.html[Amazon EBS volume modification limits]
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
modules/configuring-the-default-pvc-size-for-your-cluster.adoc(1 hunks)
🔇 Additional comments (1)
modules/configuring-the-default-pvc-size-for-your-cluster.adoc (1)
32-35: Driver identifier and error text verified. The CSI driver name is “ebs.csi.aws.com” and the official error is
Client.VolumeModificationRateExceeded: You've reached the maximum modification rate per volume limit. Wait at least 6 hours between modifications per EBS volume.(docs.aws.amazon.com, repost.aws)
| When resizing a PVC backed by AWS EBS in {productname-short}, you might see the following error message: | ||
|
|
||
| [source,terminal] | ||
| ---- | ||
| "VolumeModificationRateExceeded: You've reached the maximum modification rate per volume limit. Wait at least 6 hours between modifications per EBS volume". | ||
| ---- | ||
| This is an AWS EBS service limit, not specific to NVIDIA NIM, KServe, or any application. | ||
| It applies to all workloads using EBS-backed PVCs. | ||
| If a PVC resize is attempted before the cooldown expires, the AWS EBS CSI driver (ebs.csi.aws.com) will fail the operation with this error. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use an admonition and state the limit explicitly (per volume, 6-hour cooldown).
This reads like a troubleshooting note, not verification. Present it as a NOTE and make the “once per 6 hours per EBS volume” rule explicit. Also prefer “Amazon EBS” on first mention.
-When resizing a PVC backed by AWS EBS in {productname-short}, you might see the following error message:
-
-[source,terminal]
-----
-"VolumeModificationRateExceeded: You've reached the maximum modification rate per volume limit. Wait at least 6 hours between modifications per EBS volume".
-----
-This is an AWS EBS service limit, not specific to NVIDIA NIM, KServe, or any application.
-It applies to all workloads using EBS-backed PVCs.
-If a PVC resize is attempted before the cooldown expires, the AWS EBS CSI driver (ebs.csi.aws.com) will fail the operation with this error.
+[NOTE]
+If your cluster runs on AWS, Amazon EBS allows only one modification of the same volume every 6 hours. Attempting to resize an EBS‑backed PVC again before the 6‑hour cooldown will fail with an error from the AWS EBS CSI driver (ebs.csi.aws.com):
+
+[source,terminal]
+----
+VolumeModificationRateExceeded: You've reached the maximum modification rate per volume limit. Wait at least 6 hours between modifications per EBS volume.
+----
+This is an Amazon EBS service limit and applies to all EBS‑backed workloads, not to any particular application.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| When resizing a PVC backed by AWS EBS in {productname-short}, you might see the following error message: | |
| [source,terminal] | |
| ---- | |
| "VolumeModificationRateExceeded: You've reached the maximum modification rate per volume limit. Wait at least 6 hours between modifications per EBS volume". | |
| ---- | |
| This is an AWS EBS service limit, not specific to NVIDIA NIM, KServe, or any application. | |
| It applies to all workloads using EBS-backed PVCs. | |
| If a PVC resize is attempted before the cooldown expires, the AWS EBS CSI driver (ebs.csi.aws.com) will fail the operation with this error. | |
| [NOTE] | |
| If your cluster runs on AWS, Amazon EBS allows only one modification of the same volume every 6 hours. Attempting to resize an EBS-backed PVC again before the 6-hour cooldown will fail with an error from the AWS EBS CSI driver (ebs.csi.aws.com): | |
| [source,terminal] | |
| ---- | |
| VolumeModificationRateExceeded: You've reached the maximum modification rate per volume limit. Wait at least 6 hours between modifications per EBS volume. | |
| ---- | |
| This is an Amazon EBS service limit and applies to all EBS-backed workloads, not to any particular application. |
🤖 Prompt for AI Agents
In modules/configuring-the-default-pvc-size-for-your-cluster.adoc around lines
26 to 35, replace the current troubleshooting text with an Asciidoc NOTE
admonition that explicitly states this is an Amazon EBS service limit and that
volume modifications are limited to once per EBS volume every 6 hours
(per-volume 6-hour cooldown); ensure the first mention reads "Amazon EBS",
phrase it as a NOTE (admonition) and clearly state the rule "once per 6 hours
per EBS volume" and that attempts before the cooldown will cause the AWS EBS CSI
driver (ebs.csi.aws.com) to fail with the VolumeModificationRateExceeded error.
Description
Adding a note about storage size after deployment is limited to once per 6 hours
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit