feat: migrate kubebuilder layout to go/v4 #1746

carlkyrillos · 2025-03-14T13:56:31Z

Description

This PR migrates the project layout from kubebuilder to go/v3 to go/v4.

The changes were made in accordance with the kubebuilder migration documentation which can be found here.

An exhaustive list of major changes can be found in the kubebuilder documentation but the notable changes are:

Controllers were moved from controllers to internal/controller
Webhooks were moved from controllers/webhooks to internal/webhook
APIs were moved from apis to api
main.go was moved to cmd/main.go
The k8s.io/api/admission/v1beta1 package was deprecated and replaced with k8s.io/api/admission/v1
The operator-sdk CLI version was bumped from 1.31.0 to 1.33.0 to be compatible with the go/v4 layout

How Has This Been Tested?

These changes were tested by building operator, bundle, and catalog images, then verifying that the DSC and DSCI CRs can be created and that they successfully reconcile.

The following images were used for testing and can be used for verification:

quay.io/ckyrillo/opendatahub-operator:rhoaieng-21155-5
quay.io/ckyrillo/opendatahub-operator-bundle:rhoaieng-21155-5
quay.io/ckyrillo/opendatahub-operator-catalog:rhoaieng-21155-5

Screenshot or short clip

Merge criteria

You have read the contributors guide.
Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

carlkyrillos · 2025-03-14T13:57:45Z

/assign @lburgazzoli

zdtsw · 2025-03-14T15:19:49Z

can we wait till ODH 2.26.0 code freeze done to merge this one? and not rush into RHOAI 2.19.0

ugiordan · 2025-03-14T15:20:24Z

@carlkyrillos Given the number of files to review, just to confirm—most of the changes are related to moving controllers to internal/controller and updating apis to api paths, correct?

can we wait till ODH 2.26.0 code freeze done to merge this one? and not rush into RHOAI 2.19.0
I also agree with @zdtsw, we should wait before merging this.

carlkyrillos · 2025-03-14T15:22:59Z

can we wait till ODH 2.26.0 code freeze done to merge this one? and not rush into RHOAI 2.19.0

@zdtsw Yes, definitely. I'll put a hold on the PR

carlkyrillos · 2025-03-14T15:23:52Z

Holding until the ODH 2.26.0 code freeze as these changes aren't required for 2.19.0

/hold

carlkyrillos · 2025-03-14T15:28:20Z

@carlkyrillos Given the number of files to review, just to confirm—most of the changes are related to moving controllers to internal/controller and updating apis to api paths, correct?

can we wait till ODH 2.26.0 code freeze done to merge this one? and not rush into RHOAI 2.19.0
I also agree with @zdtsw, we should wait before merging this.

@ugiordan That's correct, the vast majority of the changes are related to moving existing files to api and internal and updating import statements across the codebase to the new paths. There are some small changes to Dockerfiles/Dockerfile, Makefile, PROJECT, and some cmd/component-codegen files but those are also just path updates.

codecov · 2025-03-14T15:46:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.14%. Comparing base (b4ab7d5) to head (89f983d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
- Coverage   24.54%   24.14%   -0.41%     
==========================================
  Files         172      171       -1     
  Lines       11874    11782      -92     
==========================================
- Hits         2915     2845      -70     
+ Misses       8679     8661      -18     
+ Partials      280      276       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

carlkyrillos · 2025-03-21T16:05:01Z