doc: explain dependency handling#3544
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated documentation in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/DESIGN.md`:
- Line 55: The sentence "In its status, the DSCI CR indicates of missing
dependencies that are not specific to a single component." contains a
grammatical error; remove the extraneous "of" so it reads "In its status, the
DSCI CR indicates missing dependencies that are not specific to a single
component." Update that exact sentence in the document (the line containing "In
its status, the DSCI CR indicates of missing dependencies...").
- Line 64: Update the sentence that currently reads "In its status, the DSC CR
indicates of missing dependencies for a specific component, or of
component-specific features that are affects by missing dependencies." by
removing the stray "of" after "indicates" and changing "affects" to "affected"
so it reads: "In its status, the DSC CR indicates missing dependencies for a
specific component, or of component-specific features that are affected by
missing dependencies." Target the sentence containing "DSC CR indicates of
missing dependencies" and edit those two words accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: ae62816e-fda1-4a08-ae84-825ac73393a6
📒 Files selected for processing (1)
docs/DESIGN.md
Signed-off-by: Arik Hadas <ahadas@redhat.com>
15d09e3 to
1098e69
Compare
Description
There has been a decision that the ODH/RHOAI operator won't deploy external operators. This PR documents this and suggests a GitOps approach based on https://github.com/opendatahub-io/odh-gitops
Merge criteria
E2E test suite update requirement
When bringing new changes to the operator code, such changes are by default required to be accompanied by extending and/or updating the E2E test suite accordingly.
To opt-out of this requirement:
E2E update requirement opt-out justificationsection belowE2E update requirement opt-out justification
Doc change
Summary by CodeRabbit