Skip to content

Commit 80ec544

Browse files
committed
Add a list of models for pytest.param
1 parent 6785119 commit 80ec544

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

tests/model_registry/model_catalog/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,8 @@ def randomly_picked_model_from_catalog_api_by_source(
203203
headers = model_registry_rest_headers
204204
else:
205205
headers = get_rest_headers(token=user_token_for_api_calls)
206-
207-
LOGGER.info(f"Picking random model from catalog: {catalog_id} with header_type: {header_type}")
208206
if not model_name:
207+
LOGGER.info(f"Picking random model from catalog: {catalog_id} with header_type: {header_type}")
209208
models_response = execute_get_command(
210209
url=f"{model_catalog_rest_url[0]}models?source={catalog_id}&pageSize=100",
211210
headers=headers,
@@ -219,6 +218,7 @@ def randomly_picked_model_from_catalog_api_by_source(
219218
assert random_model.get("source_id") == catalog_id, f"Catalog ID (source_id) mismatch for model {model_name}"
220219
LOGGER.info(f"Testing model '{model_name}' from catalog '{catalog_id}'")
221220
else:
221+
LOGGER.info(f"Looking for pre-selected model: {model_name} from catalog: {catalog_id}")
222222
# check if the model exists:
223223
random_model = execute_get_command(
224224
url=f"{model_catalog_rest_url[0]}sources/{catalog_id}/models/{model_name}",

tests/model_registry/model_catalog/test_model_artifact_search.py

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import pytest
22
from typing import Self, Any
3-
3+
import random
44
from ocp_resources.config_map import ConfigMap
55
from tests.model_registry.model_catalog.utils import (
66
fetch_all_artifacts_with_dynamic_paging,
@@ -15,7 +15,13 @@
1515

1616
LOGGER = get_logger(name=__name__)
1717
pytestmark = [pytest.mark.usefixtures("updated_dsc_component_state_scope_session", "model_registry_namespace")]
18-
MODEL_NAME_ARTIFACT_SEARCH = "RedHatAI/Llama-3.1-8B-Instruct"
18+
MODEL_NAMEs_ARTIFACT_SEARCH: list[str] = [
19+
"RedHatAI/Llama-3.1-8B-Instruct",
20+
"RedHatAI/Mistral-Small-3.1-24B-Instruct-2503-FP8-dynamic",
21+
"RedHatAI/Mistral-Small-3.1-24B-Instruct-2503-quantized.w4a16",
22+
"RedHatAI/Mistral-Small-3.1-24B-Instruct-2503-quantized.w8a8",
23+
"RedHatAI/Mixtral-8x7B-Instruct-v0.1",
24+
]
1925

2026

2127
class TestSearchArtifactsByFilterQuery:
@@ -76,7 +82,7 @@ def test_search_artifacts_by_invalid_filter_query(
7682
{
7783
"catalog_id": VALIDATED_CATALOG_ID,
7884
"header_type": "registry",
79-
"model_name": MODEL_NAME_ARTIFACT_SEARCH,
85+
"model_name": random.choice(MODEL_NAMEs_ARTIFACT_SEARCH),
8086
},
8187
"hardware_type.string_value = 'ABC-1234'",
8288
None,
@@ -87,7 +93,7 @@ def test_search_artifacts_by_invalid_filter_query(
8793
{
8894
"catalog_id": VALIDATED_CATALOG_ID,
8995
"header_type": "registry",
90-
"model_name": MODEL_NAME_ARTIFACT_SEARCH,
96+
"model_name": random.choice(MODEL_NAMEs_ARTIFACT_SEARCH),
9197
},
9298
"requests_per_second.double_value > 15.0",
9399
[{"key_name": "requests_per_second", "key_type": "double_value", "comparison": "min", "value": 15.0}],
@@ -98,7 +104,7 @@ def test_search_artifacts_by_invalid_filter_query(
98104
{
99105
"catalog_id": VALIDATED_CATALOG_ID,
100106
"header_type": "registry",
101-
"model_name": MODEL_NAME_ARTIFACT_SEARCH,
107+
"model_name": random.choice(MODEL_NAMEs_ARTIFACT_SEARCH),
102108
},
103109
"hardware_count.int_value = 8",
104110
[{"key_name": "hardware_count", "key_type": "int_value", "comparison": "exact", "value": 8}],
@@ -109,7 +115,7 @@ def test_search_artifacts_by_invalid_filter_query(
109115
{
110116
"catalog_id": VALIDATED_CATALOG_ID,
111117
"header_type": "registry",
112-
"model_name": MODEL_NAME_ARTIFACT_SEARCH,
118+
"model_name": random.choice(MODEL_NAMEs_ARTIFACT_SEARCH),
113119
},
114120
"(hardware_type.string_value = 'H100') AND (ttft_p99.double_value < 200)",
115121
[
@@ -123,7 +129,7 @@ def test_search_artifacts_by_invalid_filter_query(
123129
{
124130
"catalog_id": VALIDATED_CATALOG_ID,
125131
"header_type": "registry",
126-
"model_name": MODEL_NAME_ARTIFACT_SEARCH,
132+
"model_name": random.choice(MODEL_NAMEs_ARTIFACT_SEARCH),
127133
},
128134
"(tps_mean.double_value <260) OR (hardware_type.string_value = 'A100-80')",
129135
[
@@ -169,7 +175,7 @@ def test_filter_query_advanced_artifact_search(
169175

170176
if expected_value is None:
171177
# Simple validation of length and size for basic filter queries
172-
assert len(result["items"]) == [], f"Filter query '{filter_query}' should return valid results"
178+
assert result["items"] == [], f"Filter query '{filter_query}' should return valid results"
173179
assert result["size"] == 0, f"Size should be 0 for filter query '{filter_query}'"
174180
LOGGER.info(
175181
f"Successfully validated that filter query '{filter_query}' returns {len(result['items'])} artifacts"

0 commit comments

Comments
 (0)