Skip to content

Commit 88e0a55

Browse files
committed
address comment 3
Signed-off-by: Milind Waykole <mwaykole@redhat.com>
1 parent 802a842 commit 88e0a55

File tree

1 file changed

+1
-8
lines changed
  • tests/model_serving/model_server/keda

1 file changed

+1
-8
lines changed

tests/model_serving/model_server/keda/utils.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from kubernetes.dynamic import DynamicClient
22
from ocp_resources.inference_service import InferenceService
33
from ocp_resources.scaled_object import ScaledObject
4-
from kubernetes.dynamic.exceptions import ResourceNotFoundError
54

65

76
def get_isvc_keda_scaledobject(client: DynamicClient, isvc: InferenceService) -> ScaledObject:
@@ -18,10 +17,4 @@ def get_isvc_keda_scaledobject(client: DynamicClient, isvc: InferenceService) ->
1817
Raises:
1918
ResourceNotFoundError: if the ScaledObject is not found.
2019
"""
21-
namespace = isvc.namespace
22-
scaled_object_name = isvc.name + "-predictor"
23-
24-
try:
25-
return ScaledObject(client=client, name=scaled_object_name, namespace=namespace, ensure_exists=True)
26-
except Exception as e:
27-
raise ResourceNotFoundError(f"{isvc.name} has no KEDA ScaledObjects: {e}")
20+
return ScaledObject(client=client, name=f"{isvc.name}-predictor", namespace=isvc.namespace, ensure_exists=True)

0 commit comments

Comments
 (0)