fix: [model_serving] renamed dyn_client to client (#982)

Signed-off-by: Milind Waykole <mwaykole@redhat.com>

Author: mwaykole

tests/model_serving/model_server/conftest.py

@@ -422,7 +422,7 @@ def user_workload_monitoring_config_map(
         yield cm
 
     # UWM PVCs are not deleted once the configmap is deleted; forcefully deleting the PVCs to avoid having left-overs
-    for pvc in PersistentVolumeClaim.get(dyn_client=admin_client, namespace=uwm_namespace):
+    for pvc in PersistentVolumeClaim.get(client=admin_client, namespace=uwm_namespace):
         pvc.clean_up()
 
 
@@ -453,7 +453,7 @@ def _is_kueue_operator_installed(admin_client: DynamicClient) -> bool:
     try:
         csvs = list(
             ClusterServiceVersion.get(
-                dyn_client=admin_client,
+                client=admin_client,
                 namespace=py_config.get("applications_namespace", "openshift-operators"),
             )
         )

tests/model_serving/model_server/kserve/inference_graph/conftest.py

@@ -67,7 +67,7 @@ def kserve_raw_headless_service_config(
         logger.info(msg="Waiting for KServe controller to be ready and configuration to propagate...")
         kserve_deployments = list(
             Deployment.get(
-                dyn_client=admin_client,
+                client=admin_client,
                 namespace=py_config.get("applications_namespace", "redhat-ods-applications"),
                 label_selector="control-plane=kserve-controller-manager",
             )

tests/model_serving/model_server/kserve/kueue/test_kueue_isvc_raw.py

@@ -103,7 +103,7 @@ def test_kueue_inference_service_raw(
             Deployment.get(
                 label_selector=",".join(deployment_labels),
                 namespace=kueue_raw_inference_service.namespace,
-                dyn_client=admin_client,
+                client=admin_client,
             )
         )
         assert len(deployments) == EXPECTED_DEPLOYMENTS, (

tests/model_serving/model_server/kserve/multi_node/utils.py

@@ -114,7 +114,7 @@ def get_pods_by_isvc_generation(client: DynamicClient, isvc: InferenceService) -
 
     if pods := list(
         Pod.get(
-            dyn_client=client,
+            client=client,
             namespace=isvc.namespace,
             label_selector=f"isvc.generation={isvc_generation}",
         )

tests/model_serving/model_server/llmd/kueue/test_kueue_llmisvc_raw.py

@@ -101,7 +101,7 @@ def test_kueue_llmd_scaleup(
             Deployment.get(
                 label_selector=",".join(selector_labels),
                 namespace=llmd_inference_service.namespace,
-                dyn_client=unprivileged_client,
+                client=unprivileged_client,
             )
         )
         assert len(deployments) == EXPECTED_DEPLOYMENTS, (

tests/model_serving/model_server/llmd/utils.py

@@ -113,7 +113,7 @@ def get_llmd_pods():
         """Get LLMD workload pods for this LLMInferenceService."""
         pods = []
         for pod in Pod.get(
-            dyn_client=client,
+            client=client,
             namespace=llm_service.namespace,
             label_selector=(
                 f"{Pod.ApiGroup.APP_KUBERNETES_IO}/part-of=llminferenceservice,"

tests/model_serving/model_server/maas_billing/utils.py

@@ -40,7 +40,7 @@ def _first_ready_llmisvc(
     or None if none are Ready.
     """
     for service in LLMInferenceService.get(
-        dyn_client=client,
+        client=client,
         namespace=namespace,
         label_selector=label_selector,
     ):

tests/model_serving/model_server/upgrade/utils.py

@@ -22,7 +22,7 @@ def verify_pod_containers_not_restarted(client: DynamicClient, component_name: s
     restarted_containers = {}
 
     for pod in Pod.get(
-        dyn_client=client,
+        client=client,
         namespace=py_config["applications_namespace"],
         label_selector=f"{Pod.ApiGroup.APP_KUBERNETES_IO}/part-of={component_name}",
     ):