fix: remove unnecessary jira references that interferes with pytest-jira plugin#1227
Merged
dbasunag merged 2 commits intoopendatahub-io:mainfrom Mar 17, 2026
Merged
Conversation
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/build-push-pr-image', '/lgtm', '/verified', '/cherry-pick', '/hold'} |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (30)
💤 Files with no reviewable changes (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (19)
📝 WalkthroughWalkthroughThis PR removes issue-tracking identifiers and adjusts docstrings/comments/log messages across tests and utilities; one test file had two Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/model_registry/model_registry/python_client/test_model_registry_creation.py (1)
99-104:⚠️ Potential issue | 🟡 MinorFix misleading test docstring for MLMD log validation.
Line 99 describes grpc-container removal, but this test validates MLMD-removal behavior via pod logs. Update the docstring to match actual test intent.
Proposed patch
def test_model_registry_pod_log_mlmd_removal( self, model_registry_deployment_containers: list[dict[str, Any]], model_registry_pod: Pod ): """ - Test to ensure removal of grpc container from model registry deployment + Test to ensure MLMD removal is reflected in model registry pod logs Steps: Create metadata database Deploys model registry using the same - Check model registry deployment for grpc container. It should not be present + Check model registry pod logs for MLMD-removal evidence """🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/model_registry/model_registry/python_client/test_model_registry_creation.py` around lines 99 - 104, Update the misleading docstring in the test in tests/model_registry/model_registry/python_client/test_model_registry_creation.py (the test that inspects pod logs for MLMD removal) so it accurately describes that the test validates MLMD-removal behavior by checking pod logs rather than verifying grpc container removal; locate the test's triple-quoted docstring (the block that currently mentions "grpc container") and replace its text with a short description of steps: set up metadata DB, deploy model registry, and assert MLMD-related log messages indicating MLMD was removed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@tests/model_registry/model_registry/python_client/test_model_registry_creation.py`:
- Around line 99-104: Update the misleading docstring in the test in
tests/model_registry/model_registry/python_client/test_model_registry_creation.py
(the test that inspects pod logs for MLMD removal) so it accurately describes
that the test validates MLMD-removal behavior by checking pod logs rather than
verifying grpc container removal; locate the test's triple-quoted docstring (the
block that currently mentions "grpc container") and replace its text with a
short description of steps: set up metadata DB, deploy model registry, and
assert MLMD-related log messages indicating MLMD was removed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 9ad904e3-ae0b-4c6b-a028-9919ecccd69f
📒 Files selected for processing (30)
tests/model_registry/mcp_servers/config/test_invalid_yaml.pytests/model_registry/mcp_servers/config/test_multi_source.pytests/model_registry/mcp_servers/config/test_named_queries.pytests/model_registry/mcp_servers/search/test_filtering.pytests/model_registry/mcp_servers/search/test_ordering.pytests/model_registry/mcp_servers/test_data_integrity.pytests/model_registry/model_catalog/catalog_config/conftest.pytests/model_registry/model_catalog/catalog_config/test_catalog_source_merge.pytests/model_registry/model_catalog/catalog_config/test_default_model_catalog.pytests/model_registry/model_catalog/catalog_config/test_default_source_inclusion_exclusion_cleanup.pytests/model_registry/model_catalog/huggingface/test_huggingface_model_search.pytests/model_registry/model_catalog/huggingface/test_huggingface_model_type_classification.pytests/model_registry/model_catalog/huggingface/test_huggingface_source_error_validation.pytests/model_registry/model_catalog/metadata/test_catalog_preview.pytests/model_registry/model_catalog/metadata/test_custom_properties.pytests/model_registry/model_catalog/metadata/test_filter_options_endpoint.pytests/model_registry/model_catalog/metadata/test_sources_endpoint.pytests/model_registry/model_catalog/rbac/test_catalog_rbac.pytests/model_registry/model_catalog/search/test_model_artifact_search.pytests/model_registry/model_catalog/search/test_model_search.pytests/model_registry/model_catalog/sorting/test_model_artifacts_sorting.pytests/model_registry/model_catalog/sorting/test_model_sorting.pytests/model_registry/model_catalog/sorting/test_sorting_functionality.pytests/model_registry/model_registry/async_job/test_async_upload_e2e.pytests/model_registry/model_registry/negative_tests/test_db_migration.pytests/model_registry/model_registry/python_client/test_model_registry_creation.pytests/model_registry/model_registry/rest_api/test_model_registry_rest_api.pytests/model_registry/model_registry/rest_api/test_model_registry_secure_db.pyutilities/inference_utils.pyutilities/infra.py
💤 Files with no reviewable changes (3)
- tests/model_registry/model_catalog/metadata/test_filter_options_endpoint.py
- tests/model_registry/model_catalog/metadata/test_catalog_preview.py
- tests/model_registry/model_registry/rest_api/test_model_registry_secure_db.py
…ira plugin Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
dbasunag
force-pushed
the
jira_refs_ai_hub
branch
from
752ec6d to
ad785bd
Compare
fege
reviewed
Mar 17, 2026
|
Status of building tag latest: success. |
ssaleem-rh
pushed a commit
to ssaleem-rh/opendatahub-tests
that referenced
this pull request
Mar 23, 2026
…ira plugin (opendatahub-io#1227) Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com> Signed-off-by: Shehan Saleem <ssaleem@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
pytest-jira plugin 0.3.22 now can automatically mark tests as xfail based on Jira ticket status when test
docstrings or markers reference Jira issues.
This is problematic for many of our test where we just use jira references for documentation purposes. This PR removes such references and only keeps the ones associated with
@pytest.mark.jiraRelated Issues
How it has been tested
Additional Requirements
Summary by CodeRabbit
Documentation
Chores