Skip to content

Fix test in sanity for Rawdeployment dsc check #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwaykole merged 4 commits into from
Mar 6, 2026
Merged

Fix test in sanity for Rawdeployment dsc check #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b126bdf
Fix test in sanity for Rawdeployment dsc check
mwaykole Mar 6, 2026
3c4feed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 6, 2026
18d64ec
Merge branch 'main' into fix-sanity
mwaykole Mar 6, 2026
b5cc953
Fix test in sanity for Rawdeployment dsc check
mwaykole Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/model_serving/model_server/kserve/components/kserve_dsc_deployment_mode/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from tests.model_serving.model_server.kserve.components.kserve_dsc_deployment_mode.utils import (
patch_dsc_default_deployment_mode,
)
from utilities.constants import ModelAndFormat
from utilities.constants import Labels, ModelAndFormat
from utilities.inference_utils import create_isvc


Expand Down Expand Up @@ -58,6 +58,7 @@ def ovms_inference_service(
storage_key=ci_endpoint_s3_secret.name,
model_format=ModelAndFormat.OPENVINO_IR,
model_version=request.param["model-version"],
labels={Labels.Kserve.NETWORKING_KSERVE_IO: Labels.Kserve.EXPOSED},
wait_for_predictor_pods=False,
) as isvc:
yield isvc
1 change: 0 additions & 1 deletion ...r/kserve/components/kserve_dsc_deployment_mode/test_kserve_dsc_default_deployment_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
}


@pytest.mark.rawdeployment
@pytest.mark.parametrize(
"default_deployment_mode_in_dsc, unprivileged_model_namespace, ovms_kserve_serving_runtime, ovms_inference_service",
[
Expand Down
4 changes: 1 addition & 3 deletions tests/model_serving/model_server/kserve/components/kserve_dsc_deployment_mode/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ def wait_for_default_deployment_mode_in_cm(config_map: ConfigMap, deployment_mod
TimeoutExpiredError: If default deployment mode value is not set in configmap

"""
LOGGER.info(
f"Wait for {{request_default_deployment_mode}} deployment mode to be set in {config_map.name} configmap"
)
LOGGER.info(f"Wait for {deployment_mode} deployment mode to be set in {config_map.name} configmap")
for sample in TimeoutSampler(
wait_timeout=Timeout.TIMEOUT_5MIN,
sleep=5,
Expand Down