Skip to content

fix: add variant-groups.ndjson to skip check for models #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbasunag merged 4 commits into from
Mar 10, 2026
Merged

fix: add variant-groups.ndjson to skip check for models #1191

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3735f72
fix: add variant-groups.ndjson to skip check for models
dbasunag Mar 10, 2026
52f5ea3
Merge branch 'main' into small_bug_fix
dbasunag Mar 10, 2026
d7e9cd7
Merge branch 'main' into small_bug_fix
dbasunag Mar 10, 2026
59407ba
Merge branch 'main' into small_bug_fix
dbasunag Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/model_registry/model_catalog/search/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,8 @@ def validate_performance_data_files_on_pod(model_catalog_pod: Pod) -> dict[str,

for provider in providers.splitlines():
required_files = ["metadata.json", "performance.ndjson", "evaluations.ndjson"]
if provider == "manifest.json":
# skip the files manifest.json and variant-groups.ndjson
if provider in ["manifest.json", "variant-groups.ndjson"]:
Comment thread
dbasunag marked this conversation as resolved.
continue
LOGGER.info(f"Checking provider: {provider}")
# Only for RedHatAI model we expect performance.ndjson file, based on edge case definition
Expand Down