[Cherry-pick][3.4ea1] fix: replace broken S3 cleanup with LlamaStack files API#1223
Merged
[Cherry-pick][3.4ea1] fix: replace broken S3 cleanup with LlamaStack files API#1223
Conversation
The S3 file cleanup was failing because boto3 is not a project dependency. Replace the direct S3 access with the LlamaStack client's files API (client.files.list/delete), which requires no additional dependencies. - Remove _cleanup_s3_files helper and its boto3 dependency - Remove S3 credential parameters from distribution fixtures - Add _cleanup_files using the LlamaStack files API - Snapshot existing file IDs before tests to only delete files created during the current test execution Signed-off-by: Ignas Baranauskas <ibaranau@redhat.com> Co-authored-by: Jorge <jgarciao@users.noreply.github.com>
4 tasks
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/lgtm', '/hold', '/cherry-pick', '/verified', '/wip', '/build-push-pr-image'} |
jgarciao
approved these changes
Mar 16, 2026
|
Status of building tag 3.4ea1: success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked #1210 into 3.4ea1. Requested by: jgarciao