Skip to content

test: add verification for spdx licenses #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fege merged 2 commits into from
Mar 16, 2026
Merged

test: add verification for spdx licenses #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c54811
test: add verification for spdx licenses
fege Mar 16, 2026
2ea7e9e
Merge branch 'main' into spdx_tests
dbasunag Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CONSTITUTION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,11 @@ All code MUST consider security implications.
- Avoid running destructive commands without explicit user confirmation
- Use detect-secrets and gitleaks pre-commit hooks to prevent secret leakage
- Test code MUST NOT introduce vulnerabilities into the tested systems
- JIRA ticket links are allowed in PRs and commit messages (our Jira is public)
- Do NOT reference internal-only resources (Jenkins, Confluence, Slack threads) in code, PRs, or commit messages
- Do NOT link embargoed or security-restricted (RH-employee-only) tickets

**Rationale**: Tests interact with production-like clusters; security lapses can have real consequences.
**Rationale**: Tests interact with production-like clusters; security lapses can have real consequences. This is a public repository — only reference publicly accessible resources.

## Test Development Standards

Expand Down
3 changes: 2 additions & 1 deletion tests/model_registry/mcp_servers/search/test_filtering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class TestMCPServerFiltering:
id="by_provider",
),
pytest.param("tags='math'", 1, CALCULATOR_SERVER_NAME, None, id="by_tags"),
pytest.param("license='BSD 3-Clause'", 1, "file-manager", ("license", "BSD 3-Clause"), id="by_license"),
Comment thread
dbasunag marked this conversation as resolved.
],
)
def test_filter_by_field(
Expand All @@ -35,7 +36,7 @@ def test_filter_by_field(
expected_name: str,
field_check: tuple[str, str] | None,
):
"""TC-API-003, TC-API-005: Test filtering MCP servers by provider and tags."""
"""TC-API-003, TC-API-005, TC-API-009: Test filtering MCP servers by provider, tags, and license."""
response = execute_get_command(
url=f"{mcp_catalog_rest_urls[0]}mcp_servers",
headers=model_registry_rest_headers,
Expand Down
1 change: 0 additions & 1 deletion tests/model_registry/mcp_servers/search/test_ordering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
class TestMCPServerOrdering:
"""RHOAIENG-51584: Tests for MCP server ordering functionality."""

@pytest.mark.xfail(reason="RHOAIENG-52448: sortOrder/orderBy not working, fix in PR #2367")
@pytest.mark.parametrize(
"sort_order",
[
Expand Down
Loading