Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ utilities/ # Shared utility functions

- **ERROR vs FAILED**: Pytest reports fixture failures as ERROR, test failures as FAILED
- **Heavy imports**: Don't import heavy resources at module level; defer to fixture scope
- **Flaky tests**: Use `pytest.skip()` with `@pytest.mark.jira("PROJ-123")`, never delete
- **Flaky tests**: Use `pytest.skip()`
- **Fixture scope**: Session fixtures in `tests/conftest.py` run once for entire suite—modify carefully

## Boundaries
Expand Down
6 changes: 0 additions & 6 deletions docs/GETTING_STARTED.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,6 @@ To skip RHOAI/ODH-related tests (for example when running in upstream), pass `--
To run tests with admin client only, pass `--tc=use_unprivileged_client:False` to pytest.


### jira integration
To skip running tests which have open bugs, [pytest_jira](https://github.com/rhevm-qe-automation/pytest_jira) plugin is used.
To run tests with jira integration, you need to set `PYTEST_JIRA_URL` and `PYTEST_JIRA_TOKEN` environment variables.
To make a test with jira marker, add: `@pytest.mark.jira(jira_id="RHOAIENG-0000", run=False)` to the test.


### Running containerized tests
Save kubeconfig file to a local directory, for example: `$HOME/kubeconfig`
To run tests in containerized environment:
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ dependencies = [
"grpcio-reflection",
"portforward>=0.7.1",
"pytest-testconfig>=0.2.0",
"pytest-jira>=0.3.21",
"pygithub>=2.5.0",
"timeout-sampler>=1.0.6",
"shortuuid>=1.0.13",
Expand All @@ -67,7 +66,6 @@ dependencies = [
"semver>=3.0.4",
"sqlalchemy>=2.0.40",
"pytest-order>=1.3.0",
"marshmallow==3.26.2,<4", # this version is needed for pytest-jira
"pytest-html>=4.1.1",
"fire",
"llama_stack_client>=0.4.0,<0.5",
Expand Down
2 changes: 0 additions & 2 deletions pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ testpaths = tests
markers =
# General
polarion: Store polarion test ID
jira: Store jira bug ID
skip_on_disconnected: Mark tests that can only be run in deployments with Internet access i.e. not on disconnected clusters.
parallel: marks tests that can run in parallel along with pytest-xdist

Expand Down Expand Up @@ -61,4 +60,3 @@ addopts =
--show-progress
--tc-file=tests/global_config.py
--tc-format=python
--jira
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def test_disabled_raw_model_authentication(self, patched_remove_raw_authenticati
)

@pytest.mark.sanity
@pytest.mark.jira("RHOAIENG-19275", run=False)
def test_raw_disable_enable_authentication_no_pod_rollout(self, http_s3_ovms_raw_inference_service):
"""Verify no pod rollout when disabling and enabling authentication"""
pod = get_pods_by_isvc_label(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def wait_for_isvc_model_status(isvc: InferenceService, target_model_state: str,
raise


@pytest.mark.jira("RHOAIENG-10765")
@pytest.mark.parametrize(
"unprivileged_model_namespace, serving_runtime_from_template, invalid_s3_models_inference_service",
[
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
)
class TestKserveModelCar:
@pytest.mark.smoke
@pytest.mark.jira("RHOAIENG-13465")
def test_model_car_no_restarts(self, model_car_inference_service):
"""Verify that model pod doesn't restart"""
pod = get_pods_by_isvc_label(
Expand All @@ -56,7 +55,6 @@ def test_model_car_no_restarts(self, model_car_inference_service):

@pytest.mark.smoke
@pytest.mark.ocp_interop
@pytest.mark.jira("RHOAIENG-12306")
def test_model_car_using_rest(self, model_car_inference_service):
"""Verify model query with token using REST"""
verify_inference_response(
Expand All @@ -69,7 +67,6 @@ def test_model_car_using_rest(self, model_car_inference_service):

@pytest.mark.smoke
@pytest.mark.ocp_interop
@pytest.mark.jira("RHOAIENG-38674")
def test_model_status_loaded(self, model_car_inference_service):
"""Verify model status on the InferenceService resource is in a valid state."""
model_status = model_car_inference_service.instance.status.modelStatus
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ def test_rest_raw_deployment_internal_route(self, s3_models_inference_service):
use_default_query=True,
)

@pytest.mark.jira("RHOAIENG-17322", run=False)
@pytest.mark.parametrize(
"patched_s3_caikit_kserve_isvc_visibility_label",
[
Expand Down Expand Up @@ -191,7 +190,6 @@ def test_rest_raw_deployment_exposed_route_with_timeout(self, s3_models_inferenc
indirect=True,
)
@pytest.mark.skip(reason="skipping grpc raw for tgis-caikit RHOAIENG-17783")
@pytest.mark.jira("RHOAIENG-17783", run=False)
class TestGrpcRawDeployment:
def test_grpc_raw_deployment_internal_route(self, s3_models_inference_service):
"""Test GRPC inference using internal route"""
Expand Down Expand Up @@ -248,7 +246,6 @@ def test_grpc_raw_deployment_exposed_route(self, patched_s3_caikit_kserve_isvc_v
indirect=True,
)
@pytest.mark.skip(reason="skipping grpc raw for tgis-caikit RHOAIENG-17783")
@pytest.mark.jira("RHOAIENG-17783", run=False)
class TestGrpcRawDeploymentTimeout:
@pytest.mark.dependency(name="test_grpc_raw_deployment_exposed_route")
def test_grpc_raw_deployment_exposed_route(self, s3_models_inference_service):
Expand Down
Loading
Loading