refactor: simplify structlog and use structlog.get_logger directly#1300
Merged
dbasunag merged 2 commits intoopendatahub-io:mainfrom Mar 25, 2026
Merged
refactor: simplify structlog and use structlog.get_logger directly#1300dbasunag merged 2 commits intoopendatahub-io:mainfrom
dbasunag merged 2 commits intoopendatahub-io:mainfrom
Conversation
jgarciao
requested review from
a team,
Raghul-M,
SB159,
andyatmiami,
brettmthompson,
dbasunag,
fege,
harshad16,
jiridanek,
jstourac,
kpunwatk,
lugi0,
mwaykole,
sheltoncyril and
threcc
as code owners
github-actions
bot
added
ModelExplainability
ModelRegistry
ModelServing
Workbenches
Utilities
labels
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/hold', '/verified', '/wip', '/lgtm', '/build-push-pr-image', '/cherry-pick'} |
dbasunag
previously approved these changes
Mar 25, 2026
Consolidate logging into utilities/logger.py: ProcessorFormatter with ConsoleRenderer (console) and JSONRenderer (file), configure_structlog() in setup_logging(), and _StructlogQueueHandler so event dicts survive the queue. Remove utilities/opendatahub_logger.py. Replace get_logger() wrapper with import structlog and structlog.get_logger(name=__name__) across tests and utilities. Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com> Made-with: Cursor Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
jgarciao
force-pushed
the
simplify-structlog-config
branch
from
23abc21 to
c0dfbcf
Compare
dbasunag
previously approved these changes
Mar 25, 2026
Eliminate the --readable-logs CLI option from the logging configuration and related documentation. Update the logging setup to use structured JSON format by default, while clarifying the log output format in the GETTING_STARTED.md file. Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
dbasunag
approved these changes
Mar 25, 2026
|
Status of building tag latest: success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate logging into utilities/logger.py: ProcessorFormatter with ConsoleRenderer (console) and JSONRenderer (file), configure_structlog() in setup_logging(), and _StructlogQueueHandler so event dicts survive the queue.
Remove utilities/opendatahub_logger.py. Replace get_logger() wrapper with import structlog and structlog.get_logger(name=name) across tests and utilities.
Made-with: Cursor