chore: minor updates to AGENTS.md and .pre-commit-config.yaml#1301
chore: minor updates to AGENTS.md and .pre-commit-config.yaml#1301dbasunag merged 2 commits intoopendatahub-io:mainfrom
Conversation
Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com> Co-Authored-By: Claude <noreply@anthropic.com>
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/verified', '/hold', '/cherry-pick', '/lgtm', '/build-push-pr-image'} |
📝 WalkthroughWalkthroughTwo configuration and documentation files modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
AGENTS.md (1)
91-91: Make the dependency-change rule explicit and enforceable.Line 91 is ambiguous when multiple Dockerfiles or build targets exist. Specify exact file path(s) and
maketarget(s) so contributors and reviewers apply one deterministic rule.As per coding guidelines, "REVIEW PRIORITIES: 2. Architectural issues and anti-patterns".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@AGENTS.md` at line 91, The rule "Adding new binaries or system-level dependencies (must also update `Dockerfile` and verify with `make build`)" in AGENTS.md is ambiguous; update that entry to explicitly list the exact Dockerfile paths and make targets contributors must update and verify (e.g., the repo root Dockerfile, ./deploy/Dockerfile, and the CI build target names such as `make build`, `make image`, or any service-specific target), and require updating the corresponding Dockerfile(s) and running the specified make target(s) before submitting a PR; also add an enforceable checklist entry for the PR template or CI job to validate that those files/targets were changed and the build passed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.pre-commit-config.yaml:
- Around line 1-2: The CI config currently sets the "autofix_prs" flag which
causes bot commits that bypass local commit-msg hooks (e.g., DCO or
conventional-commit checks); either set "autofix_prs" to false to stop
pre-commit.ci from making auto-fix commits or keep it false and instead enforce
commit-msg policy server-side (push rules) so bot commits are validated; if you
must keep automated messages, consider using "autofix_commit_msg" only to
standardize text but note it will not trigger local commit-msg hooks — update
the "ci" block to disable "autofix_prs" and/or add server-side push-rule
enforcement for the commit-msg hook.
---
Nitpick comments:
In `@AGENTS.md`:
- Line 91: The rule "Adding new binaries or system-level dependencies (must also
update `Dockerfile` and verify with `make build`)" in AGENTS.md is ambiguous;
update that entry to explicitly list the exact Dockerfile paths and make targets
contributors must update and verify (e.g., the repo root Dockerfile,
./deploy/Dockerfile, and the CI build target names such as `make build`, `make
image`, or any service-specific target), and require updating the corresponding
Dockerfile(s) and running the specified make target(s) before submitting a PR;
also add an enforceable checklist entry for the PR template or CI job to
validate that those files/targets were changed and the build passed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 30b05a2b-fc14-45c5-86a6-c5de715019b7
📒 Files selected for processing (2)
.pre-commit-config.yamlAGENTS.md
|
Status of building tag latest: success. |
Pull Request
Summary
Related Issues
Please review and indicate how it has been tested
Additional Requirements
Summary by CodeRabbit