Skip to content

test: adjust to work with 3.4 and 3.4-ea2 version#1305

Merged
dbasunag merged 3 commits intoopendatahub-io:mainfrom
fege:operator_fix
Mar 26, 2026
Merged

test: adjust to work with 3.4 and 3.4-ea2 version#1305
dbasunag merged 3 commits intoopendatahub-io:mainfrom
fege:operator_fix

Conversation

@fege
Copy link
Copy Markdown
Contributor

@fege fege commented Mar 26, 2026

Pull Request

Summary

Related Issues

  • Fixes:
  • JIRA:

Please review and indicate how it has been tested

  • Locally
  • Jenkins

Additional Requirements

  • If this PR introduces a new test image, did you create a PR to mirror it in disconnected environment?
  • If this PR introduces new marker(s)/adds a new component, was relevant ticket created to update relevant Jenkins job?

Summary by CodeRabbit

  • Tests
    • Enhanced test portability by transitioning catalog configuration paths from absolute to relative file references, enabling tests to run more reliably across different environments.
    • Updated test error message validation expectations to align with current error reporting format.
    • Refined test data configuration to ensure accurate server licensing information.

Signed-off-by: fege <fmosca@redhat.com>
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/cherry-pick', '/hold', '/wip', '/build-push-pr-image', '/verified', '/lgtm'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a28dd222-7c9b-4c3a-8f42-98ef027d9bc7

📥 Commits

Reviewing files that changed from the base of the PR and between 8a67a44 and 4bed99c.

📒 Files selected for processing (2)
  • tests/model_registry/mcp_servers/config/test_invalid_yaml.py
  • tests/model_registry/mcp_servers/constants.py

📝 Walkthrough

Walkthrough

Test configuration constants for MCP server catalogs were updated from absolute to relative file paths, and an expected log error message was adjusted to match a different string format. A license field value was also changed in test data.

Changes

Cohort / File(s) Summary
MCP Catalog Path Configuration
tests/model_registry/mcp_servers/constants.py
Replaced absolute /data/user-sources/... paths with relative filenames for MCP_SERVERS_YAML_CATALOG_PATH, MCP_SERVERS_YAML2_CATALOG_PATH, MCP_SERVERS_YAML_INVALID_CATALOG_PATH, and MCP_SERVERS_YAML3_CATALOG_PATH. Changed license field for database-connector server from "MIT" to "PostgreSQL".
Test Error Message Assertion
tests/model_registry/mcp_servers/config/test_invalid_yaml.py
Removed leading prefix Error reading MCP catalog from in the expected log error message for the malformed_yaml test case, now matching format {MCP_SERVERS_YAML_INVALID_CATALOG_PATH}: instead.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references adjusting tests for versions 3.4 and 3.4-ea2, but the actual changes only modify YAML paths and a license field unrelated to version compatibility. The title should accurately reflect the actual changes: converting absolute paths to relative paths in test constants and updating a license field, not version adjustments.
Description check ⚠️ Warning The description is a bare template with no actual content. The Summary section is empty, Related Issues are unfilled, and no testing details are provided beyond checking the 'Locally' box. Fill in the Summary section with concrete details about why paths were changed to relative and why the license field was updated. Document what these changes actually test.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@dbasunag dbasunag merged commit 9ab3b25 into opendatahub-io:main Mar 26, 2026
9 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

@fege fege deleted the operator_fix branch March 26, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants