fix: enable PositionalArgumentsFormatter in logger#1307
fix: enable PositionalArgumentsFormatter in logger#1307jgarciao merged 1 commit intoopendatahub-io:mainfrom
Conversation
Fixes possitional arguments not being formatted properly in the
logs
LOGGER.info(
"Uploading dataset (%d document(s)) to vector_store (id=%s)",
len(dataset.documents),
vector_store.id,
)
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/build-push-pr-image', '/verified', '/lgtm', '/hold', '/wip', '/cherry-pick'} |
|
/lgtm |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Security considerations: Verify that positional arguments passed to logging calls don't contain untrusted data that could expose sensitive information. If positional args originate from external input, ensure they're sanitized prior to logging to prevent information disclosure or injection attacks. 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Status of building tag latest: success. |
Fixes positional arguments not being formatted properly in the logs
Summary by CodeRabbit