Skip to content

Fix Tempo tracing field name and null data handling in API response #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbasunag merged 3 commits into from
Apr 1, 2026
+2 −3
Merged

Fix Tempo tracing field name and null data handling in API response #1337

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e11b936
fix: use correct CRD field name 'enableTraces' instead of 'enableTrac…
Sandeep20013 Apr 1, 2026
81f9eba
fix: handle null response from Tempo services API
Sandeep20013 Apr 1, 2026
8c3647e
Merge branch 'main' into fix/tempo-null-data-handling
kpunwatk Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/fixtures/guardrails.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def guardrails_orchestrator(
"otlpMetricsEndpoint": metrics_endpoint,
"otlpTracesEndpoint": traces_endpoint,
"enableMetrics": True,
"enableTracing": True,
"enableTraces": True,
}

with GuardrailsOrchestrator(**gorch_kwargs, teardown=teardown_resources) as gorch:
Expand Down
3 changes: 1 addition & 2 deletions tests/model_explainability/guardrails/test_guardrails.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,7 @@ def test_guardrails_traces_in_tempo(

@retry(wait_timeout=Timeout.TIMEOUT_1MIN, sleep=5)
def check_traces():
services = requests.get(f"{tempo_traces_service_portforward}/api/services").json().get("data", [])

services = requests.get(f"{tempo_traces_service_portforward}/api/services").json().get("data") or []
guardrails_services = [s for s in services if "guardrails" in s]
if not guardrails_services:
return False
Expand Down