feat: Add fixture to install the MariaDB operator#177
Merged
rnetser merged 2 commits intoopendatahub-io:mainfrom Mar 17, 2025
Merged
feat: Add fixture to install the MariaDB operator#177rnetser merged 2 commits intoopendatahub-io:mainfrom
rnetser merged 2 commits intoopendatahub-io:mainfrom
Conversation
Contributor
Author
|
/verified |
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/hold', '/wip', '/verified', '/lgtm'} |
dbasunag
previously approved these changes
Mar 14, 2025
rnetser
suggested changes
Mar 16, 2025
Contributor
rnetser
left a comment
rnetser
left a comment
There was a problem hiding this comment.
small changed to re-use name
| deployment = Deployment( | ||
| client=admin_client, | ||
| namespace=operator_ns.name, | ||
| name="mariadb-operator-helm-controller-manager", |
Contributor
There was a problem hiding this comment.
Suggested change
| name="mariadb-operator-helm-controller-manager", | |
| name=f"{operator_name}-helm-controller-manager", |
adolfo-ab
force-pushed
the
install-mariadb-operator
branch
from
06393c8 to
1ed5030
Compare
Contributor
Author
|
/verified |
dbasunag
approved these changes
Mar 17, 2025
rnetser
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fixture to install the MariaDB operator, used in some TrustyAIService tests.
Description
Some TrustyAIService tests use the MariaDB operator. As of now we can't expect it to be installed in the cluster by default, since only a few tests use it, and is not a required operator for ODH/RHOAI. So we need to install/uninstall from the test setup through a fixture. We also check if the operator is already installed before attempting the installation, to prevent ConflictError.
How Has This Been Tested?
Running the tests in a working cluster
Merge criteria: