Skip to content

[Explainability] Add tests for GuardrailsOrchestrator#185

Merged
rnetser merged 3 commits intoopendatahub-io:mainfrom
adolfo-ab:gorch-test
Mar 20, 2025
Merged

[Explainability] Add tests for GuardrailsOrchestrator#185
rnetser merged 3 commits intoopendatahub-io:mainfrom
adolfo-ab:gorch-test

Conversation

@adolfo-ab
Copy link
Copy Markdown
Contributor

@adolfo-ab adolfo-ab commented Mar 18, 2025

Add tests for GuardrailsOrchestrator

Note: Closed other PR because it got messed up while solving conflicts during rebase

Description

In this test we deploy all the resources necessary to deploy and run GuardrailsOrchestrator, along with an LLM, and check the basic endpoints for the orchestrator to make sure it's deployed correctly. More tests checking actual detection will be provided in another PR.

How Has This Been Tested?

Running the tests on a working cluster.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@adolfo-ab adolfo-ab requested a review from a team as a code owner March 18, 2025 14:32
@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@github-actions github-actions bot added Verified Verified pr in Jenkins size/xl labels Mar 18, 2025
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/hold', '/wip', '/verified', '/lgtm'}

@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@github-actions github-actions bot added Verified Verified pr in Jenkins and removed Verified Verified pr in Jenkins labels Mar 18, 2025
rnetser
rnetser previously approved these changes Mar 18, 2025
@github-actions github-actions bot removed the Verified Verified pr in Jenkins label Mar 19, 2025
@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@github-actions github-actions bot added the Verified Verified pr in Jenkins label Mar 19, 2025
@github-actions github-actions bot removed the Verified Verified pr in Jenkins label Mar 20, 2025
@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@github-actions github-actions bot added the Verified Verified pr in Jenkins label Mar 20, 2025
@github-actions github-actions bot removed the Verified Verified pr in Jenkins label Mar 20, 2025
@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@github-actions github-actions bot added the Verified Verified pr in Jenkins label Mar 20, 2025
mwaykole
mwaykole previously approved these changes Mar 20, 2025
@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@adolfo-ab adolfo-ab dismissed stale reviews from mwaykole and rnetser via 4c2de92 March 20, 2025 10:47
@github-actions github-actions bot removed the Verified Verified pr in Jenkins label Mar 20, 2025
@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/review

@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@github-actions github-actions bot added the Verified Verified pr in Jenkins label Mar 20, 2025
@rnetser rnetser merged commit f755739 into opendatahub-io:main Mar 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants