Skip to content

Fix error in drift tests#187

Merged
rnetser merged 1 commit intoopendatahub-io:mainfrom
adolfo-ab:fix-drift-tests
Mar 18, 2025
Merged

Fix error in drift tests#187
rnetser merged 1 commit intoopendatahub-io:mainfrom
adolfo-ab:fix-drift-tests

Conversation

@adolfo-ab
Copy link
Copy Markdown
Contributor

Needed to cast str for ports used in ServingRuntime, otherwise fixture fails with UnprocessableEntity error

How Has This Been Tested?

Running tests in working cluster

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@adolfo-ab adolfo-ab requested a review from a team as a code owner March 18, 2025 15:22
@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/wip', '/lgtm', '/verified', '/hold'}

@github-actions github-actions bot added size/xs Verified Verified pr in Jenkins labels Mar 18, 2025
@rnetser rnetser merged commit 059d898 into opendatahub-io:main Mar 18, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs Verified Verified pr in Jenkins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants