Skip to content

updates to test_registering_model() based on previous review comments#227

Merged
dbasunag merged 1 commit intoopendatahub-io:mainfrom
dbasunag:main
Apr 8, 2025
Merged

updates to test_registering_model() based on previous review comments#227
dbasunag merged 1 commit intoopendatahub-io:mainfrom
dbasunag:main

Conversation

@dbasunag
Copy link
Copy Markdown
Collaborator

@dbasunag dbasunag commented Apr 7, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dbasunag dbasunag requested a review from a team as a code owner April 7, 2025 22:38
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2025

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/verified', '/hold', '/lgtm', '/wip'}

@fege
Copy link
Copy Markdown
Contributor

fege commented Apr 8, 2025

/lgtm

@dbasunag
Copy link
Copy Markdown
Collaborator Author

dbasunag commented Apr 8, 2025

/verified

@opendatahub-tests-bot opendatahub-tests-bot added the Verified Verified pr in Jenkins label Apr 8, 2025
@dbasunag dbasunag merged commit 3bc6745 into opendatahub-io:main Apr 8, 2025
8 of 11 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2025

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants