Skip to content

feat: move to marking test branches#229

Closed
rnetser wants to merge 77 commits intoopendatahub-io:mainfrom
rnetser:product-version
Closed

feat: move to marking test branches#229
rnetser wants to merge 77 commits intoopendatahub-io:mainfrom
rnetser:product-version

Conversation

@rnetser
Copy link
Copy Markdown
Contributor

@rnetser rnetser commented Apr 8, 2025

Instead of branching in the repo, tests can now be:

  • marked as "upsteam", for upstream-only features
  • marked as "odh", for mistream features
  • marked with rhoai version on which they were developed, e.g pytest.mark.rhoai_2_16; only tests which meet the installed product version will be selected.

@rnetser rnetser requested a review from a team as a code owner April 8, 2025 15:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2025

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
Supported labels

{'/lgtm', '/wip', '/hold', '/verified'}

Copy link
Copy Markdown
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks ok to me, but as far as I can see we're only filtering tests based on the version marker; how do we want to handle the midstream/upstream markers?

jira: Store jira bug ID

# Distributions and supported downstream markers
upstream: Mark tests as ones suitable to run only upstream.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we handle when a feature behavior changes between releases and when test step changes between releases?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about adding the option to add an indicator like
up_to_rhoai_2_16 and there will be another test with the new functionality which will have rhoai_2_17 ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would add duplicate tests and the repository can potentially get messy and hard to maintain. I don't like this idea.

adolfo-ab
adolfo-ab previously approved these changes Apr 9, 2025
@rnetser
Copy link
Copy Markdown
Contributor Author

rnetser commented Apr 9, 2025

addressed in #231

@rnetser rnetser closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants