feat: move to marking test branches#229
feat: move to marking test branches#229rnetser wants to merge 77 commits intoopendatahub-io:mainfrom
Conversation
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/lgtm', '/wip', '/hold', '/verified'} |
lugi0
left a comment
There was a problem hiding this comment.
this looks ok to me, but as far as I can see we're only filtering tests based on the version marker; how do we want to handle the midstream/upstream markers?
| jira: Store jira bug ID | ||
|
|
||
| # Distributions and supported downstream markers | ||
| upstream: Mark tests as ones suitable to run only upstream. |
There was a problem hiding this comment.
How would we handle when a feature behavior changes between releases and when test step changes between releases?
There was a problem hiding this comment.
how about adding the option to add an indicator like
up_to_rhoai_2_16 and there will be another test with the new functionality which will have rhoai_2_17 ?
There was a problem hiding this comment.
This would add duplicate tests and the repository can potentially get messy and hard to maintain. I don't like this idea.
|
addressed in #231 |
Instead of branching in the repo, tests can now be:
pytest.mark.rhoai_2_16; only tests which meet the installed product version will be selected.