Skip to content

remove unnecessary argument from function call #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnetser merged 3 commits into from
Apr 17, 2025
Merged

remove unnecessary argument from function call #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
558d938
on rebase clean commented-by- labels
dbasunag Apr 15, 2025
9618fdd
Merge branch 'opendatahub-io:main' into main
dbasunag Apr 15, 2025
fe74e76
remove unnecessary argument from function call
dbasunag Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/model_registry/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,9 @@ def model_registry_instance_service(

@pytest.fixture(scope="class")
def model_registry_instance_rest_endpoint(
admin_client: DynamicClient,
model_registry_instance_service: Service,
) -> str:
return get_endpoint_from_mr_service(
client=admin_client, svc=model_registry_instance_service, protocol=Protocols.REST
)
return get_endpoint_from_mr_service(svc=model_registry_instance_service, protocol=Protocols.REST)


@pytest.fixture(scope="class")
Expand Down
2 changes: 1 addition & 1 deletion tests/model_registry/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def get_mr_service_by_label(client: DynamicClient, ns: Namespace, mr_instance: M
raise ResourceNotFoundError(f"{mr_instance.name} has no Service")


def get_endpoint_from_mr_service(client: DynamicClient, svc: Service, protocol: str) -> str:
def get_endpoint_from_mr_service(svc: Service, protocol: str) -> str:
if protocol in (Protocols.REST, Protocols.GRPC):
return svc.instance.metadata.annotations[f"{ADDRESS_ANNOTATION_PREFIX}{protocol}"]
else:
Expand Down