Skip to content

inferece - catch when 503 error is retured #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbasunag merged 3 commits into from
Apr 28, 2025
Merged

inferece - catch when 503 error is retured #274

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a89c5e6
fix: address 503
rnetser Apr 26, 2025
4035543
ci: merge main branch
rnetser Apr 28, 2025
0ef6772
ci: merge main branch
rnetser Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions utilities/inference_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import re
import shlex
from contextlib import contextmanager
from http import HTTPStatus
from json import JSONDecodeError
from string import Template
from typing import Any, Optional, Generator
Expand All @@ -15,7 +16,7 @@
from simple_logger.logger import get_logger
from timeout_sampler import TimeoutWatch, retry

from utilities.exceptions import InvalidStorageArgumentError
from utilities.exceptions import InferenceResponseError, InvalidStorageArgumentError
from utilities.infra import (
get_inference_serving_runtime,
get_model_route,
Expand Down Expand Up @@ -433,7 +434,14 @@ def run_inference(self, cmd: str) -> str:
else:
res, out, err = run_command(command=shlex.split(cmd), verify_stderr=False, check=False)

if not res:
if res:
if f"http/1.0 {HTTPStatus.SERVICE_UNAVAILABLE}" in out.lower():
raise InferenceResponseError(
f"The Route for {self.get_inference_url()} is not ready yet. "
f"Got {HTTPStatus.SERVICE_UNAVAILABLE} error."
)

else:
raise ValueError(f"Inference failed with error: {err}\nOutput: {out}\nCommand: {cmd}")

LOGGER.info(f"Inference output:\n{out}")
Expand Down