Skip to content

Wait for dsc and dsci ready state in cluster_sanity check #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbasunag merged 1 commit into from
May 6, 2025
Merged

Wait for dsc and dsci ready state in cluster_sanity check #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions utilities/infra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,16 +851,33 @@ def wait_for_isvc_pods(client: DynamicClient, isvc: InferenceService, runtime_na
return get_pods_by_isvc_label(client=client, isvc=isvc, runtime_name=runtime_name)


def verify_dsci_status_ready(dsci_resource: DSCInitialization) -> None:
LOGGER.info(f"Verify DSCI {dsci_resource.name} are {dsci_resource.Status.READY}.")
if dsci_resource.status != dsci_resource.Status.READY:
raise ResourceNotReadyError(f"DSCI {dsci_resource.name} is not ready.\nStatus: {dsci_resource.instance.status}")
@retry(
wait_timeout=120,
sleep=5,
exceptions_dict={ResourceNotReadyError: []},
)
def wait_for_dsci_status_ready(dsci_resource: DSCInitialization) -> bool:
LOGGER.info(f"Wait for DSCI {dsci_resource.name} to be in {dsci_resource.Status.READY} status.")
if dsci_resource.status == dsci_resource.Status.READY:
return True

raise ResourceNotReadyError(
f"DSCI {dsci_resource.name} is not ready.\nCurrent status: {dsci_resource.instance.status}"
)


def verify_dsc_status_ready(dsc_resource: DataScienceCluster) -> None:
LOGGER.info(f"Verify DSC {dsc_resource.name} are {dsc_resource.Status.READY}.")
if dsc_resource.status != dsc_resource.Status.READY:
raise ResourceNotReadyError(f"DSC {dsc_resource.name} is not ready.\nStatus: {dsc_resource.instance.status}")
@retry(
wait_timeout=120,
sleep=5,
exceptions_dict={ResourceNotReadyError: []},
)
def wait_for_dsc_status_ready(dsc_resource: DataScienceCluster) -> bool:
LOGGER.info(f"Wait for DSC {dsc_resource.name} are {dsc_resource.Status.READY}.")
if dsc_resource.status == dsc_resource.Status.READY:
return True
raise ResourceNotReadyError(
f"DSC {dsc_resource.name} is not ready.\nCurrent status: {dsc_resource.instance.status}"
)


def verify_cluster_sanity(
Expand Down Expand Up @@ -898,8 +915,8 @@ def verify_cluster_sanity(
LOGGER.warning(f"Skipping RHOAI resource checks, got {skip_rhoai_check}")

else:
verify_dsci_status_ready(dsci_resource=dsci_resource)
verify_dsc_status_ready(dsc_resource=dsc_resource)
wait_for_dsci_status_ready(dsci_resource=dsci_resource)
wait_for_dsc_status_ready(dsc_resource=dsc_resource)

except (ResourceNotReadyError, NodeUnschedulableError, NodeNotReadyError) as ex:
error_msg = f"Cluster sanity check failed: {str(ex)}"
Expand Down