Skip to content

feat: update guardrails tests#299

Merged
adolfo-ab merged 1 commit intoopendatahub-io:mainfrom
adolfo-ab:improve-guardrails
May 9, 2025
Merged

feat: update guardrails tests#299
adolfo-ab merged 1 commit intoopendatahub-io:mainfrom
adolfo-ab:improve-guardrails

Conversation

@adolfo-ab
Copy link
Copy Markdown
Contributor

@adolfo-ab adolfo-ab commented May 8, 2025

Update guardrails tests according to latest changes to the GuardrailsOrchestrator CR

Summary by CodeRabbit

  • Tests
    • Updated test fixtures to consolidate configuration parameters and improve clarity.
    • Removed unused fixture to streamline test setup.
  • Style
    • Cleaned up unnecessary trailing blank lines in utility functions for improved code readability.

@adolfo-ab adolfo-ab requested a review from a team as a code owner May 8, 2025 12:58
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 8, 2025

Walkthrough

The changes update test fixtures related to guardrails configuration in the model explainability guardrails tests, consolidating and renaming configuration parameters and removing an obsolete fixture. Additionally, minor whitespace cleanup was performed in utility functions for TrustyAI service tests, without affecting logic or behavior.

Changes

File(s) Change Summary
tests/model_explainability/guardrails/conftest.py Consolidated and renamed fixtures: replaced vllm_gateway_config and vllm_images_configmap with guardrails_gateway_config; updated fixture signatures and configuration contents; removed vllm_images_configmap fixture.
tests/model_explainability/trustyai_service/trustyai_service_utils.py Removed two trailing blank lines from two functions; no logic or functional changes.

Poem

In the warren of tests, some fixtures did hop,
Old configs retired, new ones now top.
With whitespace trimmed and names made clear,
The code is refreshed—springtime is here!
Guardrails stand sturdy, TrustyAI shines bright,
🐇 Cheers for clean changes, all through the night!

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 958a56c and 00ec405.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • tests/model_explainability/guardrails/conftest.py (3 hunks)
  • tests/model_explainability/trustyai_service/trustyai_service_utils.py (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/model_explainability/trustyai_service/trustyai_service_utils.py
🧰 Additional context used
🧬 Code Graph Analysis (1)
tests/model_explainability/guardrails/conftest.py (1)
tests/conftest.py (2)
  • admin_client (50-51)
  • model_namespace (97-117)
🔇 Additional comments (3)
tests/model_explainability/guardrails/conftest.py (3)

48-62: LGTM: Updated GuardrailsOrchestrator fixture successfully.

The changes properly align the test fixture with the latest GuardrailsOrchestrator CR by:

  1. Using the more generic guardrails_gateway_config parameter name instead of the VLLM-specific one
  2. Adding the new required parameters enable_built_in_detectors=True and enable_guardrails_gateway=True

These updates ensure the tests accurately reflect the current implementation of the GuardrailsOrchestrator resource.


163-165: LGTM: Appropriate fixture renaming.

Renaming this fixture from vllm_gateway_config to guardrails_gateway_config maintains consistency with the parameter changes in the GuardrailsOrchestrator fixture and properly reflects the more generic nature of the gateway configuration.


178-188: LGTM: Enhanced detector configuration with input/output flags.

The updated configuration correctly reflects changes to the GuardrailsOrchestrator API by:

  1. Adding explicit "input": True and "output": True flags for detectors, enabling granular control over where each detector is applied
  2. Including an additional "other_detector" entry with the same flags

These changes provide more flexibility in how detectors are applied to requests and responses in the guardrails pipeline.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@adolfo-ab
Copy link
Copy Markdown
Contributor Author

/verified

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 8, 2025

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
Supported labels

{'/lgtm', '/verified', '/wip', '/hold'}

@adolfo-ab adolfo-ab merged commit 212b8d9 into opendatahub-io:main May 9, 2025
9 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 9, 2025

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants