Skip to content

Set temp value to 0 to reduce the randomness of the output for vllm output#304

Merged
tarukumar merged 2 commits intoopendatahub-io:mainfrom
tarukumar:temp
May 15, 2025
Merged

Set temp value to 0 to reduce the randomness of the output for vllm output#304
tarukumar merged 2 commits intoopendatahub-io:mainfrom
tarukumar:temp

Conversation

@tarukumar
Copy link
Copy Markdown
Contributor

@tarukumar tarukumar commented May 12, 2025

Summary by CodeRabbit

  • Refactor
    • Adjusted the temperature setting for AI requests to always use a value of 0, including for embeddings, ensuring consistent behavior across all supported endpoints.

Signed-off-by: Tarun Kumar <takumar@redhat.com>
@tarukumar tarukumar requested a review from a team as a code owner May 12, 2025 08:22
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 12, 2025

Walkthrough

The update modifies the _construct_request_data method in the OpenAI plugin utility to set the temperature parameter to 0 for all endpoint types, including chat completions, embeddings, and other prompts. For the embeddings endpoint, the temperature parameter is now explicitly included in the request data.

Changes

File(s) Change Summary
utilities/plugins/openai_plugin.py Updated _construct_request_data to set temperature to 0 for all endpoint types, and added temperature to the embeddings endpoint data.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant OpenAIPlugin

    Caller->>OpenAIPlugin: Call _construct_request_data(endpoint_type, ...)
    OpenAIPlugin->>OpenAIPlugin: Build data dictionary
    OpenAIPlugin->>OpenAIPlugin: Set temperature = 0 for all endpoint types
    OpenAIPlugin->>OpenAIPlugin: Add temperature to embeddings data
    OpenAIPlugin-->>Caller: Return constructed request data
Loading

Poem

A tweak to the code, cool as can be,
Temperature zero—now set universally!
Even embeddings get their chill,
In every request, calm and still.
The plugin now sends with frosty delight,
Hopping ahead, everything just right!
🐇❄️

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfcf992 and ccd6b1b.

📒 Files selected for processing (1)
  • utilities/plugins/openai_plugin.py (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
utilities/plugins/openai_plugin.py (1)
utilities/plugins/constant.py (1)
  • OpenAIEnpoints (1-6)
🔇 Additional comments (3)
utilities/plugins/openai_plugin.py (3)

162-162: LGTM: Setting temperature to 0 eliminates randomness in responses

Setting the temperature to 0 is a good approach to ensure deterministic outputs from the language model, which will make testing and validation more reliable.


170-170: LGTM: Setting temperature to 0 for consistent outputs

Setting the temperature to 0 for all prompt types ensures consistent, deterministic outputs across the application, which is beneficial for testing and reproducibility.


164-168:

Details

❓ Verification inconclusive

Verify appropriateness of temperature parameter for embeddings endpoint

While setting temperature to 0 aligns with the goal of reducing randomness, embedding models typically don't use a temperature parameter as they're designed to be deterministic by default. This parameter might be ignored by the standard OpenAI API.

Additionally, I noticed that encoding_format is set to 0.1, which seems unusual. The OpenAI embeddings API typically expects encoding_format to be a string like "float" or "base64", not a float value.


🏁 Script executed:

#!/bin/bash
# Check OpenAI API documentation for embeddings parameters
curl -s https://api.openai.com/v1/embeddings -H "Content-Type: application/json" -H "Authorization: Bearer sk-dummy" -d '{"model": "text-embedding-ada-002", "input": "test"}' | grep -i "parameter"

Length of output: 196


Verify Embeddings Parameters in openai_plugin.py

Please confirm against the latest OpenAI Embeddings API documentation that the parameters you’re passing are supported:

• File: utilities/plugins/openai_plugin.py
Lines 164–168

    data = {
        "input": query["text"],
        "encoding_format": 0.1,
        "temperature": 0,
    }

• The temperature field is generally ignored by embedding endpoints (they’re deterministic).
• The encoding_format value is typically a string enum (e.g. "float" or "base64"), not a numeric literal.

Refer to the OpenAI Embeddings API docs to verify the correct parameter names and value types, then update or remove any unsupported fields.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
Supported labels

{'/wip', '/lgtm', '/verified', '/hold'}

@jiridanek
Copy link
Copy Markdown
Member

reduce the randomness

only reduce? shouldn't this completely eliminate any randomness from the output?

@jiridanek jiridanek changed the title Set temp value to 0 to redcue the randomness of the output for vllm output Set temp value to 0 to reduce the randomness of the output for vllm output May 12, 2025
@tarukumar tarukumar merged commit 5dbfc8d into opendatahub-io:main May 15, 2025
8 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

dbasunag pushed a commit to dbasunag/opendatahub-tests that referenced this pull request May 15, 2025
dbasunag pushed a commit to dbasunag/opendatahub-tests that referenced this pull request May 15, 2025
dbasunag pushed a commit to dbasunag/opendatahub-tests that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants