Skip to content

remove version check for validate_authorino_operator_version_channel#363

Merged
dbasunag merged 1 commit intoopendatahub-io:mainfrom
dbasunag:remove_check
Jun 20, 2025
Merged

remove version check for validate_authorino_operator_version_channel#363
dbasunag merged 1 commit intoopendatahub-io:mainfrom
dbasunag:remove_check

Conversation

@dbasunag
Copy link
Copy Markdown
Collaborator

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dbasunag dbasunag requested a review from a team as a code owner June 18, 2025 18:26
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 18, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Removed a test fixture that checked the Authorino operator's version and subscription channel in certain scenarios.

Summary by CodeRabbit

  • Tests
    • Removed a test fixture that previously checked the installation and version of the Authorino operator during test runs.
  • Utilities
    • Removed a function that validated the subscription channel of an operator in a Kubernetes namespace.

Walkthrough

The change removes the package-scoped pytest fixture validate_authorino_operator_version_channel from tests/model_registry/conftest.py and deletes the validate_operator_subscription_channel function from utilities/operator_utils.py along with its related imports. No other code or fixtures were modified.

Changes

File(s) Change Summary
tests/model_registry/conftest.py Removed the validate_authorino_operator_version_channel fixture and its related imports.
utilities/operator_utils.py Removed the validate_operator_subscription_channel function and its related imports.

Possibly related PRs

Suggested labels

size/m


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74593d6 and 3d2e9eb.

📒 Files selected for processing (2)
  • tests/model_registry/conftest.py (0 hunks)
  • utilities/operator_utils.py (0 hunks)
💤 Files with no reviewable changes (2)
  • utilities/operator_utils.py
  • tests/model_registry/conftest.py
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: tox-tests
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/lgtm', '/build-push-pr-image', '/cherry-pick', '/wip', '/verified', '/hold'}

@dbasunag
Copy link
Copy Markdown
Collaborator Author

/build-push-pr-image

@github-actions
Copy link
Copy Markdown

Status of building tag pr-363: success.
Status of pushing tag pr-363 to image registry: success.

@dbasunag dbasunag merged commit 93d3972 into opendatahub-io:main Jun 20, 2025
10 checks passed
@dbasunag dbasunag deleted the remove_check branch June 20, 2025 01:14
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants