Skip to content

remove cert verification for oc download #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lugi0 merged 3 commits into from
Jun 20, 2025
Merged

remove cert verification for oc download #366

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fca1db1
remove cert verification for oc download
dbasunag Jun 19, 2025
2635646
Merge branch 'main' into oc_download
dbasunag Jun 20, 2025
323d70d
Merge branch 'main' into oc_download
lugi0 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions utilities/infra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import platform
import pytest
import requests
import urllib3
from _pytest._py.path import LocalPath
from _pytest.fixtures import FixtureRequest
from kubernetes.dynamic import DynamicClient
Expand Down Expand Up @@ -1184,16 +1185,6 @@ def get_oc_console_cli_download_link() -> str:
return all_links[0]


def get_server_cert(tmpdir: LocalPath) -> str:
data = ConfigMap(name="kube-root-ca.crt", namespace="openshift-apiserver", ensure_exists=True).instance.data[
"ca.crt"
]
file_path = os.path.join(tmpdir, "cluster-ca.cert")
with open(file_path, "w") as fd:
fd.write(data)
return file_path


def download_oc_console_cli(tmpdir: LocalPath) -> str:
"""
Download and extract the OpenShift CLI binary.
Expand All @@ -1209,9 +1200,9 @@ def download_oc_console_cli(tmpdir: LocalPath) -> str:
"""
oc_console_cli_download_link = get_oc_console_cli_download_link()
LOGGER.info(f"Downloading archive using: url={oc_console_cli_download_link}")
cert_file = get_server_cert(tmpdir=tmpdir)
urllib3.disable_warnings() # TODO: remove when cert issue is addressed for managed clusters
local_file_name = os.path.join(tmpdir, oc_console_cli_download_link.split("/")[-1])
with requests.get(oc_console_cli_download_link, verify=cert_file, stream=True) as created_request:
with requests.get(oc_console_cli_download_link, verify=False, stream=True) as created_request:
created_request.raise_for_status()
with open(local_file_name, "wb") as file_downloaded:
for chunk in created_request.iter_content(chunk_size=8192):
Expand Down