skip for 2.21

[mwaykole]

No description provided.

[github-actions]

The following are automatically added/executed:

• PR size label.
• Run pre-commit
• Run tox
• Add PR author as the PR assignee
• Build image based on the PR

Available user actions:

• To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
• To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
• To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
  lgtm label removed on each new commit push.
• To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
  verified label removed on each new commit push.
• To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
  and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
• To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
  pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.

Supported labels

{'/lgtm', '/hold', '/build-push-pr-image', '/verified', '/cherry-pick', '/wip'}

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Temporarily skipped two test classes related to Kueue inference service for the 2.21 release. No changes to test logic or application functionality.

Walkthrough

Skip decorators were added to two test classes in separate test files, causing all tests within these classes to be skipped for the 2.21 release. No other logic, parameters, or assertions were modified in either file.

Changes

Files	Change Summary
tests/model_serving/model_server/kueue/test_kueue_isvc_raw.py	Added @pytest.mark.skip to TestKueueInferenceServiceRaw test class.
tests/model_serving/model_server/kueue/test_kueue_isvc_serverless.py	Added @pytest.mark.skip to TestKueueInferenceServiceServerless test class.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

The base branch was changed.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

tests/model_serving/model_server/kueue/test_kueue_isvc_serverless.py (1)

41-43: Prefer skipif tied to the target release instead of a blanket skip

A hard-coded @pytest.mark.skip risks the test remaining disabled indefinitely.
Guard the skip behind an explicit condition (e.g., env var or semantic-version check) so that the test suite automatically re-enables once the 2.21 line is no longer under test.

-import pytest
+import os
+import pytest
...
-@pytest.mark.skip(reason="Skipping test for 2.21 release")
+@pytest.mark.skipif(
+    os.getenv("SERVE_RELEASE") == "2.21",
+    reason="Temporarily skipped for 2.21 release",
+)

This also documents exactly when the skip should cease to apply.
(Remove the extra @pytest.mark.serverless decorator if the class is already covered by the module-level pytestmark list.)

tests/model_serving/model_server/kueue/test_kueue_isvc_raw.py (1)

39-41: Make the skip conditional to avoid long-term test rot

Same rationale as the serverless test: wrap the skip in a condition keyed to the 2.21 release (or a feature flag) so the test automatically returns once the window passes.

-import pytest
+import os
+import pytest
...
-@pytest.mark.skip(reason="Skipping test for 2.21 release")
+@pytest.mark.skipif(
+    os.getenv("SERVE_RELEASE") == "2.21",
+    reason="Temporarily skipped for 2.21 release",
+)

Helps ensure these important admission-control checks don’t quietly vanish from CI forever.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe8c0e and 76f9ac7.

📒 Files selected for processing (2)

• tests/model_serving/model_server/kueue/test_kueue_isvc_raw.py (1 hunks)
• tests/model_serving/model_server/kueue/test_kueue_isvc_serverless.py (1 hunks)