Skip to content

TestServerlessCanaryRollout Fix#383

Merged
mwaykole merged 1 commit intoopendatahub-io:mainfrom
mwaykole:TestServerlessCanaryRolloutFix
Jun 26, 2025
Merged

TestServerlessCanaryRollout Fix#383
mwaykole merged 1 commit intoopendatahub-io:mainfrom
mwaykole:TestServerlessCanaryRolloutFix

Conversation

@mwaykole
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
@mwaykole mwaykole requested a review from a team as a code owner June 26, 2025 16:25
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/cherry-pick', '/lgtm', '/verified', '/wip', '/hold', '/build-push-pr-image'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 26, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated the expected canary rollout traffic percentage in test verification from 30% to 70%.

Walkthrough

The test parameter for expected canary traffic percentage in the test_serverless_during_canary_rollout method was updated from 30% to 70%. This change adjusts the test's validation criteria for canary rollout traffic distribution. No other modifications were made to the test logic or public interfaces.

Changes

Files Change Summary
tests/model_serving/model_server/serverless/test_canary_rollout.py Updated expected_percentage in a test from 30 to 70.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 906091d and c6a7dc0.

📒 Files selected for processing (1)
  • tests/model_serving/model_server/serverless/test_canary_rollout.py (1 hunks)
🔇 Additional comments (1)
tests/model_serving/model_server/serverless/test_canary_rollout.py (1)

63-63: ```shell
#!/bin/bash

Show the canary rollout test around where canary-traffic-percent is configured

rg -n "canary-traffic-percent" -A 5 -B 5 tests/model_serving/model_server/serverless/test_canary_rollout.py

Show the fixture definition for inference_service_updated_canary_config

rg -n "def inference_service_updated_canary_config" -A 20 tests/model_serving/model_server/serverless/test_canary_rollout.py


</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEejqANiS7RpuAMqUpFK4kQBhTGgqyASvgsLfDxIADF4AA8DADlsZgFKLgBmAA4kgwBVRETIZgB3NFkAawCSI31jcCgyenwAMxwCYjJlGnomVnYuXn5hUXEpGXkmJSpVdS0dCpMoOFRUTEbCUnIqNoVOjE5IKjzIRDjmb3k5BVGVNU1tXTBDStMDGkRcRAB6ZkUSCwB9bIoJeAYIjvT4/P7OV7gyiuN5PXDfBheHzfCgBIJ4DTcWQcAwAInxBgAxITIABBACSzVW1Do+0Ox34DQYsEwpEQZlgJEgcJ43jQbBofAABiQItx+nRvuKKAx2GhSEKUFhcJzIEK4b8nNDpIhvrRsBRAUQEUjZCi0cFcIqBbBFJACshmazaXVUcxIEkAAzc/CQADsno0MAQyA+tHgdXg0m5qtF4rEtNwVDqkYYPEosq28q5+sNQJjXMRGAZqMClp4LOySoL3LskGcEfgiPE+CwzxI3AANEqGBQSGhEEaa5hxAx4Nwae1Tdzk6n9iy+5BXSwPZ6AKQ+/3roPRX34FWURgsoHRgg1nlBIhN/h8CdUAWUZB5Shco5KDRGIzEskWQXUeCtsgZ4HpASgMBYfIthgyD1JAcb4BQ6wITw2ACBY17sOoUbsgYUC7kezpAb6IFgRBawAdBjJwWKCFIbeqHoWmmHiNIH74ri5S3Pc1QYLUDRoHgywtGstIdGwWxcLsdKsAypwjMo4xXFMXEzBszDqN88C0LqfYAiQz60L8uDeLgNx3KpDAAGxoH6tAMJ6foAJy0AArAAjG5tCOWgSQACwpL5jkpI5dRJI5np1LQdRuSkbmeo5JAAEwBWgZncWpGlaTpJB6QZ3w1GZQA== -->

<!-- internal state end -->
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

- [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate Docstrings

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=opendatahub-io/opendatahub-tests&utm_content=383):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@Raghul-M
Copy link
Copy Markdown
Contributor

/lgtm

@mwaykole mwaykole added the Verified Verified pr in Jenkins label Jun 26, 2025
@mwaykole mwaykole merged commit 5c82373 into opendatahub-io:main Jun 26, 2025
8 of 9 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants