Skip to content

Fix: Add annotations regarding s3 related information for serviceaccount #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbasunag merged 1 commit into from
Jun 30, 2025
Merged

Fix: Add annotations regarding s3 related information for serviceaccount #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion utilities/infra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,19 @@ def s3_endpoint_secret(
yield secret

else:
# Determine usehttps based on endpoint protocol
usehttps = 0
if aws_s3_endpoint.startswith("https://"):
usehttps = 1
with Secret(
annotations={f"{ApiGroups.OPENDATAHUB_IO}/connection-type": "s3"},
annotations={
f"{ApiGroups.OPENDATAHUB_IO}/connection-type": "s3",
"serving.kserve.io/s3-endpoint": (aws_s3_endpoint.replace("https://", "").replace("http://", "")),
"serving.kserve.io/s3-region": aws_s3_region,
"serving.kserve.io/s3-useanoncredential": "false",
"serving.kserve.io/s3-verifyssl": "0",
"serving.kserve.io/s3-usehttps": str(usehttps),
},
# the labels are needed to set the secret as data connection by odh-model-controller
label={
Labels.OpenDataHubIo.MANAGED: "true",
Expand Down