feat: add pre-commit to uv dependencies by sheltoncyril · Pull Request #427 · opendatahub-io/opendatahub-tests

sheltoncyril · 2025-07-11T17:50:50Z

adding pre-commit as a dependency as pre-commit gets uninstalled when uv sync is performed

coderabbitai · 2025-07-11T17:50:57Z

📝 Walkthrough

Summary by CodeRabbit

Chores
- Added the pre-commit tool as a project dependency.

Walkthrough

The change updates the project's configuration by adding the pre-commit package (version 4.2.0 or higher) as a dependency in the pyproject.toml file. No other dependencies or metadata were modified.

Changes

File	Change Summary
pyproject.toml	Added `pre-commit>=4.2.0` to the dependencies list.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-11T17:51:08Z

The following are automatically added/executed:

PR size label.
Run pre-commit
Run tox
Add PR author as the PR assignee
Build image based on the PR

Available user actions:

To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
lgtm label removed on each new commit push.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.

Supported labels

{'/hold', '/wip', '/verified', '/lgtm', '/cherry-pick', '/build-push-pr-image'}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

pyproject.toml (1)
73-73: Prefer keeping pre-commit in the dev dependency list

pre-commit is strictly a development-time tool; bundling it in [project].dependencies means it will be installed in every production/CI runtime that consumes the package—even when hooks are never invoked—adding unnecessary weight and potential attack surface.

Consider moving it to the existing [tool.uv].dev-dependencies array:
@@
-    "llama_stack_client==0.2.10",
-    "pre-commit>=4.2.0",
+    "llama_stack_client==0.2.10",
 ]
@@
 [tool.uv]
 dev-dependencies = [
     "ipdb>=0.13.13",
     "ipython>=8.12.3",
+    "pre-commit>=4.2.0",
 ]
If the goal is solely to prevent uv sync from uninstalling pre-commit, pinning it as a dev-dependency achieves the same outcome without bloating runtime environments.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8db035 and a1cc723.

⛔ Files ignored due to path filters (1)

uv.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

pyproject.toml (1 hunks)

dbasunag · 2025-07-12T02:42:07Z

pyproject.toml

    "pytest-html>=4.1.1",
    "fire",
    "llama_stack_client==0.2.10",
+    "pre-commit>=4.2.0",


Precommit should not be needed with in uv. Why do we need it?

Got it, closing it as this was discussed offline. Thanks!

feat: add pre-commit to uv dependencies

a1cc723

sheltoncyril requested a review from a team as a code owner July 11, 2025 17:50

github-actions bot assigned sheltoncyril Jul 11, 2025

github-actions bot added the size/xxl label Jul 11, 2025

coderabbitai bot reviewed Jul 11, 2025

View reviewed changes

dbasunag requested changes Jul 12, 2025

View reviewed changes

rhods-ci-bot added the changes-requested-by-dbasunag label Jul 12, 2025

sheltoncyril closed this Jul 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add pre-commit to uv dependencies#427

feat: add pre-commit to uv dependencies#427
sheltoncyril wants to merge 1 commit intoopendatahub-io:mainfrom
sheltoncyril:add-pre-commit-to-deps

sheltoncyril commented Jul 11, 2025

Uh oh!

coderabbitai bot commented Jul 11, 2025 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

dbasunag Jul 12, 2025

Uh oh!

sheltoncyril Jul 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sheltoncyril commented Jul 11, 2025

Uh oh!

coderabbitai bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

dbasunag Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

sheltoncyril Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Jul 11, 2025 •

edited

Loading