Skip to content

Exclude __snapshot__ folder from secret detection check#431

Merged
dbasunag merged 2 commits intoopendatahub-io:mainfrom
rpancham:add_pre-commit_exception
Jul 14, 2025
Merged

Exclude __snapshot__ folder from secret detection check#431
dbasunag merged 2 commits intoopendatahub-io:mainfrom
rpancham:add_pre-commit_exception

Conversation

@vaibhavjainwiz
Copy link
Copy Markdown
Member

Description

pre-commit.ci is failing with false positive scenerio. There is no secret inTestONNXModel.test_onnx_inference[densenetonnx-serverless-grpc-deployment].json & TestONNXModel.test_onnx_inference[densenetonnx-raw-grpc-deployment].json file. We could ignore them.

Secret Type: Base64 High Entropy String
Location:    tests/model_serving/model_runtime/triton/basic_model_deployment/__snapshots__/test_onnx_model/TestONNXModel.test_onnx_inference[densenetonnx-serverless-grpc-deployment].json:15

Secret Type: Base64 High Entropy String
Location:    tests/model_serving/model_runtime/triton/basic_model_deployment/__snapshots__/test_onnx_model/TestONNXModel.test_onnx_inference[densenetonnx-raw-grpc-deployment].json:15

These snapshot files are auto-generate. We can't add comment into it. We need to add a rule in pre-commit-config.yaml file to not scan the snapshots folder.

I verified with below configuration. pre-commit is working with it.

  - repo: https://github.com/Yelp/detect-secrets
    rev: v1.5.0
    hooks:
      - id: detect-secrets
        exclude: .*/__snapshots__/.*

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Vaibhav Jain <vajain@redhat.com>
@vaibhavjainwiz vaibhavjainwiz requested a review from a team as a code owner July 14, 2025 16:48
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 14, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated configuration to exclude certain files from secret scanning.

Walkthrough

An exclusion pattern was added to the detect-secrets hook configuration in the .pre-commit-config.yaml file to prevent scanning of files within any __snapshots__ directory. No other configuration or code changes were made.

Changes

File(s) Change Summary
.pre-commit-config.yaml Added an exclusion regex to the detect-secrets hook to skip files in __snapshots__ directories.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ffcedf2 and e905573.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/build-push-pr-image', '/cherry-pick', '/lgtm', '/wip', '/verified', '/hold'}

@dbasunag dbasunag merged commit b5b4e2e into opendatahub-io:main Jul 14, 2025
10 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

@coderabbitai coderabbitai bot mentioned this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants