RHAIENG-191 - Use LlamaStackDistribution from openshift wrappers

[jiripetrlik]

No description provided.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Refactor
  • Updated dependencies to use an external implementation for distribution management.
  • Simplified deployment checks for improved reliability.
  • Adjusted environment and configuration settings related to server deployment.

Walkthrough

The changes replace the local definition of the LlamaStackDistribution class in utilities/rag_utils.py with an import from ocp_resources.llama_stack_distribution. Corresponding updates are made in tests/rag/conftest.py to adjust imports, modify fixture configuration values, and increase a deployment timeout.

Changes

Cohort / File(s)	Change Summary
Test Fixture Updates tests/rag/conftest.py	Updated import of LlamaStackDistribution to use ocp_resources.llama_stack_distribution; removed import of TimeoutSampler; adjusted fixture configuration by replacing image specification with distribution name, removed storage size and environment variable MILVUS_DB_PATH, and increased deployment timeout from 15 seconds polling loop to a 2-minute wait call.
Class Definition Removal and Import Refactor utilities/rag_utils.py	Removed the local LlamaStackDistribution class definition; now imports this class from ocp_resources.llama_stack_distribution instead. No other changes to logic or usage within the file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• RHOAIENG-24934 - Test infrastructure for RAG #335: Introduced the original local LlamaStackDistribution class and related test fixtures, which are now being refactored in this PR.

Suggested labels

size/l

Suggested reviewers

• jiripetrlik
• lugi0
• jgarciao

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 729c501 and 06eafaa.

📒 Files selected for processing (2)

• tests/rag/conftest.py (3 hunks)
• utilities/rag_utils.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• utilities/rag_utils.py
• tests/rag/conftest.py

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

The following are automatically added/executed:

• PR size label.
• Run pre-commit
• Run tox
• Add PR author as the PR assignee
• Build image based on the PR

Available user actions:

• To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
• To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
• To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
  lgtm label removed on each new commit push.
• To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
  verified label removed on each new commit push.
• To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
  and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
• To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
  pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.

Supported labels

{'/wip', '/build-push-pr-image', '/verified', '/hold', '/lgtm', '/cherry-pick'}

[jiripetrlik]

/verified

[github-actions]

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

[jiripetrlik]

/cherry-pick 2.23

[rhods-ci-bot]

Cherry pick action created PR #470 successfully 🎉!
See: https://github.com/opendatahub-io/opendatahub-tests/actions/runs/16593920085