add separate command line option for custom namespace tests

[dbasunag]

Description

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[github-actions]

The following are automatically added/executed:

• PR size label.
• Run pre-commit
• Run tox
• Add PR author as the PR assignee
• Build image based on the PR

Available user actions:

• To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
• To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
• To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
  lgtm label removed on each new commit push.
• To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
  verified label removed on each new commit push.
• To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
  and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
• To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
  pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.

Supported labels

{'/lgtm', '/hold', '/verified', '/cherry-pick', '/build-push-pr-image', '/wip'}

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Added a command-line option to run model registry tests against a custom namespace.
  • Introduced a new pytest marker to label tests using a custom namespace.

• Bug Fixes

  • Standardized namespace configuration across model registry tests for consistency.

• Chores

  • Simplified and cleaned up test parameterizations and imports.
  • Removed unused constants and files.
  • Added a new constant for custom namespace usage in tests.

Walkthrough

This change introduces a new pytest command-line flag to control whether model registry tests use a custom namespace. It updates fixtures and test parameterizations to standardize on the configured namespace, removes indirect parameterization, adds a custom pytest marker, and cleans up related imports and constants. Namespace configuration is now centralized.

Changes

Cohort / File(s)	Change Summary
Pytest CLI and Global Config conftest.py, utilities/constants.py, pytest.ini	Added a pytest CLI option --custom-namespace for model registry tests; updated global config logic to use a custom or default namespace; introduced MODEL_REGISTRY_CUSTOM_NAMESPACE constant; added new pytest marker custom_namespace.
Model Registry Component Fixture Refactor tests/model_registry/conftest.py	Refactored updated_dsc_component_state_scope_class fixture to use a fixed patch and standardized namespace from config, removing dynamic parameterization.
Negative Test Namespace Handling tests/model_registry/negative_tests/conftest.py, tests/model_registry/negative_tests/constants.py	Changed fixture to always use the configured custom namespace; removed the constants file and related fallback logic.
Test Parameterization and Marker Updates tests/model_registry/negative_tests/test_db_migration.py, tests/model_registry/negative_tests/test_model_registry_creation_negative.py, tests/model_registry/python_client/test_model_registry_creation.py, tests/model_registry/rbac/test_mr_rbac.py, tests/model_registry/rbac/test_mr_rbac_sa.py, tests/model_registry/rest_api/mariadb/test_mr_mariadb.py, tests/model_registry/rest_api/test_model_registry_rest_api.py, tests/model_registry/rest_api/test_model_registry_secure_db.py, tests/model_registry/scc/test_model_registry_scc.py, tests/model_registry/image_validation/test_verify_rhoai_images.py	Removed indirect parameterization for namespace/config patches; updated tests to use the new config-driven namespace logic; added or updated use of the custom_namespace marker; cleaned up related imports and parameters.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• add test to validate container images for MR #311: Refactored the same fixture (updated_dsc_component_state_scope_class); this PR further modifies its configuration logic for namespace handling.

Suggested labels

size/l

Suggested reviewers

• lugi0
• sheltoncyril

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f75b8eb and 83ef5f6.

📒 Files selected for processing (2)

• pytest.ini (1 hunks)
• utilities/constants.py (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• utilities/constants.py
• pytest.ini

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fege]

/lgtm

[dbasunag]

/build-push-pr-image

[github-actions]

Status of building tag pr-480: success.
Status of pushing tag pr-480 to image registry: success.

[github-actions]

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.