test(workbenches): bump default Notebook CR image version#489
Merged
dbasunag merged 1 commit intoopendatahub-io:mainfrom Aug 5, 2025
Merged
test(workbenches): bump default Notebook CR image version#489dbasunag merged 1 commit intoopendatahub-io:mainfrom
dbasunag merged 1 commit intoopendatahub-io:mainfrom
Conversation
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe version tag for the minimal workbench image used in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/build-push-pr-image', '/lgtm', '/hold', '/verified', '/wip', '/cherry-pick'} |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
tests/workbenches/conftest.py (1)
88-93: Fallback path builds an invalid container image referenceIf
internal_image_registryis absent,minimal_image_pathbecomes":2025.1"—a tag with no repository/image name, which Kubernetes will reject (ErrImagePull). Preserve the full image string instead:-else ":" + minimal_image.rsplit(":", maxsplit=1)[1] +else minimal_image # keep “jupyter-minimal-notebook:2025.1” or “s2i-minimal-notebook:2025.1”
🧹 Nitpick comments (1)
tests/workbenches/conftest.py (1)
64-64: Drop the redundant expression in the f-string or lift the tag into a constant
f"{image_name}:{'2025.1'}"works, but the inner string literal wrapped in{}is superfluous and obscures at-a-glance grep-ability for the tag. Either:
- Inline plainly
yield f"{image_name}:2025.1"- Or define a module-level
MINIMAL_IMAGE_TAG = "2025.1"so future bumps touch a single place.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/workbenches/conftest.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
jiridanek
approved these changes
Aug 4, 2025
dbasunag
approved these changes
Aug 5, 2025
|
Status of building tag latest: success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just update the workbench image for the Notebook check to the latest greatest version.
How Has This Been Tested?
Merge criteria: